Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error handle null user attribute value #288

Merged
merged 2 commits into from
Nov 29, 2022
Merged

fix: Error handle null user attribute value #288

merged 2 commits into from
Nov 29, 2022

Conversation

FelipeCoro
Copy link
Contributor

Summary

  • Added null check for userAttribute value in FilteredMParticleUser.java onUserAttributesReceived().

Testing Plan

  • All CI test should pass.

Reference Issue

markvdouw
markvdouw approved these changes Nov 29, 2022
View reviewed changes
Copy link

@markvdouw markvdouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but shouldnt we consider this change into unit tests?

@mchuangatmp mchuangatmp changed the title fix: Firebase kit function signature mismatch. fix: Error handle null user attribute value Nov 29, 2022
@mchuangatmp mchuangatmp merged commit 73872df into mParticle:development Nov 29, 2022
samdozor added a commit that referenced this pull request Nov 30, 2022
@samdozor
Revert "fix: Error handle null user attribute value (#288)"
45acde6 
This reverts commit 73872df.
mparticle-automation added a commit that referenced this pull request Dec 2, 2022
@mparticle-automation
chore: 5.48.3 (release)
fbb2f16 
## [5.48.3](v5.48.2...v5.48.3) (2022-12-02)

### Bug Fixes

* Error handle null user attribute better and add use case to test file ([#290](#290)) ([8412478](8412478))
* Error handle null user attribute value ([#288](#288)) ([73872df](73872df))

### Updates & Maintenance

* Add in ktlintCheck to daily cron job ([#284](#284)) ([1d23a5f](1d23a5f))
* Update submodules ([375b0d3](375b0d3))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.48.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markvdouw markvdouw markvdouw approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FelipeCoro @mparticle-automation @markvdouw @mchuangatmp