Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add callback functionality to upload method #492

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

fix: Add callback functionality to upload method #492

wants to merge 3 commits into from

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Added callback functionality to the upload method. The callback parameter is only required when using it with the 'doUpload()' method in the 'MessageManager' class.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested locally and with new unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

einsteinx2
einsteinx2 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@samdozor samdozor Awaiting requested review from samdozor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mansi-mParticle @einsteinx2