fix: Check for uploader to prevent errors when calling upload() too e…

…arly (#938)
mParticle · Nov 6, 2024 · b8a1a8f · b8a1a8f
1 parent 3b1aa42
commit b8a1a8f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/mp-instance.js b/src/mp-instance.js
@@ -591,7 +591,7 @@ export default function mParticleInstance(instanceName) {
                     Constants.NativeSdkPaths.Upload
                 );
             } else {
-                self._APIClient.uploader.prepareAndUpload(false, false);
+                self._APIClient?.uploader?.prepareAndUpload(false, false);
             }
         }
     };

diff --git a/test/src/tests-batchUploader.ts b/test/src/tests-batchUploader.ts
@@ -329,6 +329,20 @@ describe('batch uploader', () => {
                 })
             });
 
+            it('should not throw an error when upload is called while storage has not been created yet', async () => {
+                window.localStorage.clear();
+                window.sessionStorage.clear();
+
+                window.mParticle.init(apiKey, window.mParticle.config);
+
+                const mpInstance = window.mParticle.getInstance();
+                const uploader = mpInstance._APIClient.uploader;
+
+                expect(uploader).to.equal(null)
+
+                expect(() => { window.mParticle.upload() }).to.not.throw(TypeError, /Cannot read properties of null \(reading 'prepareAndUpload'\)/)
+            });
+
             it('should return batches that fail to unknown HTTP errors', async () => {
                 window.mParticle.init(apiKey, window.mParticle.config);