Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for window.screen when setting device_info #936

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • There are cases where window exists, but window.screen doesn't, so we need to add a check for that.

Testing Plan

  • Was this tested locally? If not, explain why. - Added a unit test
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@rmi22186 rmi22186 merged commit 7ce742f into staging Oct 15, 2024
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants