Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add Type interfaces for cookie sync manager #940

Merged
merged 3 commits into from
Nov 5, 2024
Merged

refactor: Add Type interfaces for cookie sync manager #940

merged 3 commits into from
Nov 5, 2024

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Introduces type interfaces for Cookie Sync Manager

Testing Plan

  • Was this tested locally? If not, explain why.
  • N/A Does not change any actual functionality

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle marked this pull request as ready for review October 26, 2024 22:22
rmi22186
rmi22186 requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit. otherwise LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexs-mparticle alexs-mparticle merged commit 2acbe37 into development Nov 5, 2024
23 of 28 checks passed
alexs-mparticle added a commit that referenced this pull request Nov 6, 2024
@alexs-mparticle
refactor: Add Type interfaces for cookie sync manager (#940)
6b15343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexs-mparticle @rmi22186