-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate CookieSyncManager to TypeScript #944
Merged
alexs-mparticle
merged 23 commits into
development
from
test/SQDSDKS-5084-cookie-sync-tests
Nov 12, 2024
Merged
refactor: Migrate CookieSyncManager to TypeScript #944
alexs-mparticle
merged 23 commits into
development
from
test/SQDSDKS-5084-cookie-sync-tests
Nov 12, 2024
+953
−320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
force-pushed
the
test/SQDSDKS-5084-cookie-sync-tests
branch
from
October 31, 2024 17:50
8e661d6
to
50cd525
Compare
alexs-mparticle
changed the base branch from
refactor/SQDSDKS-4800-cookie-sync-interfaces
to
development
November 7, 2024 16:25
alexs-mparticle
force-pushed
the
test/SQDSDKS-5084-cookie-sync-tests
branch
from
November 7, 2024 16:30
50cd525
to
e139d03
Compare
rmi22186
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the jest tests are awesome. THANK YOU. minor nits mostly i'd say, and some commentary.
Co-authored-by: Robert Ing <rmi22186@gmail.com>
rmi22186
reviewed
Nov 7, 2024
rmi22186
requested changes
Nov 7, 2024
rmi22186
reviewed
Nov 7, 2024
rmi22186
reviewed
Nov 7, 2024
alexs-mparticle
commented
Nov 8, 2024
rmi22186
reviewed
Nov 8, 2024
Co-authored-by: Robert Ing <rmi22186@gmail.com>
Quality Gate failedFailed conditions |
rmi22186
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
development
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)