Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add Type interfaces for identity api client #945

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Create Type Interfaces for Identity API Client

Testing Plan

  • Was this tested locally? If not, explain why.
  • N/A - Defines new type interfaces but they will not be used until we refactor api client

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle added the refactor Changes to the structure of the code label Nov 7, 2024
@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-6678-identity-api-client-interfaces branch from 1568db5 to c16c104 Compare November 7, 2024 16:55
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, but see my comment about PR-ing into a feature branch so that the unused interface is appropriately used and shown to be working. not a hill i'd die on (especially for less complicated interfaces such as https://github.com/mParticle/mparticle-web-sdk/pull/946/files), and i'm open to just merging it straight in. but figured good to discuss.

Copy link

sonarcloud bot commented Nov 8, 2024

@alexs-mparticle alexs-mparticle merged commit d019fe0 into development Nov 8, 2024
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants