Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add Type interfaces for native sdk helpers #946

Merged

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Create Interfaces for Native JS SDK Helpers

Testing Plan

  • Was this tested locally? If not, explain why.
  • N/A - This just defines new interfaces. Automated tests should continue to pass and the project should continue to build.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle added the refactor Changes to the structure of the code label Nov 7, 2024
@rmi22186 rmi22186 self-requested a review November 8, 2024 14:07
Copy link

sonarcloud bot commented Nov 8, 2024

@alexs-mparticle alexs-mparticle merged commit 957749b into development Nov 8, 2024
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants