Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for TikTok Click and Cookie Ids #956

Open
wants to merge 6 commits into
base: feat/click-ids
Choose a base branch
from

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Dec 5, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Adds TikTok Click and Cookie IDs to custom_flags and partner_identities properties of Events and Batches, respectively.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Using a sample app, add TikTok Click ID (ttclid) to query param and Cookie ID (_ttp) to cookies. Verify that TikTok.ClickId appears in Event Custom Flags and tiktok_cookie_id appears in Batch partner_identities
  • Confirm these values persist into Live Stream and User Activity View in mParticle Dashboard.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle marked this pull request as ready for review December 5, 2024 21:08
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great structural change overall! A few comments, mostly nits.

src/integrationCapture.ts Outdated Show resolved Hide resolved
src/integrationCapture.ts Outdated Show resolved Hide resolved
src/sdkToEventsApiConverter.ts Outdated Show resolved Hide resolved
src/sdkToEventsApiConverter.ts Show resolved Hide resolved
src/sdkToEventsApiConverter.ts Outdated Show resolved Hide resolved
src/integrationCapture.ts Outdated Show resolved Hide resolved
test/jest/integration-capture.spec.ts Show resolved Hide resolved
test/jest/integration-capture.spec.ts Outdated Show resolved Hide resolved
test/jest/integration-capture.spec.ts Outdated Show resolved Hide resolved
alexs-mparticle and others added 2 commits December 10, 2024 13:29
Co-authored-by: Robert Ing <rmi22186@gmail.com>
Copy link

sonarcloud bot commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants