refactor: Update Error handling for Identity API Client #959
+592
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
added
wait to merge
refactor
rmi22186
requested changes
Dec 9, 2024
src/identityApiClient.ts
Outdated
Comment on lines
251
to
269
| case HTTP_OK: | ||
| case HTTP_ACCEPTED: | ||
| message = 'Received Identity Response from server: '; | ||
| message += JSON.stringify(identityResponse.responseText); | ||
| break; | ||
|
|
||
| default: { | ||
| // 400 has an error message, but 403 doesn't | ||
| const errorResponse: IdentityApiErrorResponse = identityResponse.responseText as unknown as IdentityApiErrorResponse; | ||
| if (errorResponse?.Errors) { | ||
| message = 'Issue with sending Identity Request to mParticle Servers, received HTTP Code of ' + identityResponse.status; | ||
|
|
||
| const errorMessage = errorResponse.Errors.map((error) => error.message).join(', '); | ||
| message += ' - ' + errorMessage; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| verbose(message); |
There was a problem hiding this comment.
Can you write a test that accounts for the message being passed through, since this is new behavior?
|
alexs-mparticle
commented
Dec 11, 2024
|
|
||
| break; | ||
|
|
||
| // 401 and 403 have no bodies and should be rejected outright |
There was a problem hiding this comment.
Note: Add specific comments as to what will cause a 401 or 403
alexs-mparticle
commented
Dec 11, 2024
| case HTTP_ACCEPTED: | ||
| case HTTP_OK: | ||
|
|
||
| // 400 error will has a body and will go through the happy path to report the error |
There was a problem hiding this comment.
Note: Add context to what would cause a 400
alexs-mparticle
commented
Dec 11, 2024
|
|
||
| break; | ||
|
|
||
| // 401 and 403 have no bodies and should be rejected outright |
There was a problem hiding this comment.
Note: Rephrase to say 'All other error codes will hit this path'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)