Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidManifest.xml #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

judgemento
Copy link

Edited to allow no camera title

@dired
Copy link

dired commented Aug 30, 2022

I wanted to fulfil this feature, to have clean hdmi. I built the project today - I will test your change in the next days. Did you actually test it?

@dired
Copy link

dired commented Aug 31, 2022

No, sorry, when I try to install my built apk with pmca-gui, I get the following error:

Traceback (most recent call last):
  File "pmca-gui.py", line 78, in do
  File "pmca\commands\usb.py", line 300, in installCommand
  File "pmca\commands\usb.py", line 73, in installApp
Exception: Communication error 100: Error completed

After successfully building the master branch.
Unfortunately I'm not an android developer and with the release version, I cannot successfully build with the error:
Gradle version 2.2 is required. Current version is 3.2.1. If using the gradle wrapper, try editing the distributionUrl

I don't know if I'm willing to spend so much time on this. If anyone could enlighten me how to install the build requirements properly I'd gladly dig a little deeper.

@dired
Copy link

dired commented Sep 2, 2022

update: I just got out of the insane nightmare to make the current master work with current android studio - to build a working apk that also can be installed on camera. Can't guarantee that my build is as stable as @ma1co's. One important/last step was to rename the package, because to "write over" the existing PMCADemo Application on the camera gave the same error as always. (might be that this was a reason why I could not get my apks to run earlier, lol)

I followed [https://github.com//issues/16], the according stackoverflow-link [https://stackoverflow.com/questions/57127685/how-to-build-old-android-project-in-android-studio] and the comments/subcomments there.
Then at some point - as a completely new android-studio user can't it describe otherwise - some magic popped up regarding gradle wrapper, and it migrated the whole thing somehow, making the build work with the simply copy-pasted code from the stackoverflow-question of @JoJ123 / the provided code from majurageerthan over there (credit where due).

I acknowledge that from this thread and comment ma1co/OpenMemories-Tweak#70 (comment) it was made clear by @ma1co to you @judgemento that the change you made in this request should suffice for our goal of the camera-bar to be removed to be achieved.

Now I'm in the position of my first comment, where I can actually test your change.
But making the compilation work so that I can run the self-built app on my camera was my first goal here, and a good point in time to stop looking at the screen for a while :D

TODO for me:

  • Going to test your change very soon,
  • if successful: wanting to publish an apk - in a fork then - that we can work with,
  • if successful: want to provide also a quickstart guide for other people to maintain a "clean" cleanhdmi solution.

offtopic:
Luckily I recorded my session so that I can actually backtrace what the hell happened in android-studio suddenly providing me with that wrapper-migration-magic that catched me offguard. It is really cumersome for a newbie to understand anything about the version differences between android-studio-plugin, gradle, compilesdk, sdk, ... ? I am not willing to learn the whole fucking thing by reading each documentation page, starting an example project etc, if the documentation does not provide the information that I need to know as a newbie in a clear manner (small rant about a topic that generally baffles me, but that was all I needed to get off my chest)

P.S.: Yes, I think this is the best place for me to write about this. Until I fork it myself, this is the place most relevant, as opposed to adding a comment somewhere to a not-100%-related issue or opening a new issue (unnecessary)

@dired
Copy link

dired commented Sep 2, 2022

End of story:

I compiled it with your change and it works as expected. This is all I hoped for.

Since I believe @ma1co is not too keen on continuing this repo, I will for now fork it and make a release with the apk.

BTW: In my research I found that another repo offers an apk, that seems to have this done already. When testing that apk, I noticed though that the Focus/Finder-Button (sorry I am no camera expert, I mean when you press the trigger half-way through) doesn't work as opposed to the original PCMADemo. Hence we are where we are, otherwise I would have stopped at that point.
Also the author claims the video quality is somehow bad - about which I could not tell a difference between "normal" HDMI-out, @ma1co's PCMADemo-Camera and @lucaspape's PCMA-CleanHDMI (being on the HX400V btw)
Here the link to where lucaspape links the apk and tells that its somehow bad ma1co/Sony-PMCA-RE#249 (comment)
Again: I found it being less good than the PCMADemo's camera app as explained.

@dired
Copy link

dired commented Sep 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants