Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smart Home functionality for switch states, energy consumption an power values #15

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

wvogel
Copy link

@wvogel wvogel commented Dec 11, 2023

Fixes #11

Avoids a runtime error with Python versions < 3.10
…t_home.py

Extended Smart Home from reading temperature sensors only to temperature (where sensor value is valid), switch states, power and energy consumption.
@ma4nn ma4nn added the enhancement New feature or request label Dec 13, 2023
@ma4nn
Copy link
Owner

ma4nn commented Dec 14, 2023

@wvogel cool thanks very much for your contribution, great enhancement👍

I have made some improvements in this branch, I hope that was OK for you:

  • made use of FritzHomeAutomation class
  • added unit tests
  • some code style optimizations to comply with pylint rules

Do you want to test the changes and update your PR or should I create a new one?

@wvogel
Copy link
Author

wvogel commented Feb 4, 2024

@ma4nn, pls. go ahead and use whatever I tried and integrate it. :)

@ma4nn ma4nn merged commit 015eb20 into ma4nn:master Jun 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart Home extended to multigraph plugin with additional values
2 participants