Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add failing audio files from GH-29 to contrib test suite #38

Merged

Conversation

mbsantiago
Copy link
Collaborator

This PR addresses issue #29, where a user encountered errors when running the batdetect2 CLI on a specific set of audio files. While the underlying issue appeared to be resolved by previous PRs (#32 and #34) related to NumPy compatibility, this PR adds further validation.

To confirm the fix:

  • Added the problematic audio files provided by @padpadpadpad to the contrib folder within the test suite.
  • Created a new test case that runs the batdetect2 CLI on these files, ensuring no errors occur.

The tests now pass without any code modifications, indicating that the issue has been successfully resolved by the previous NumPy-related fixes.

Acknowledgments:

Thanks to @fhaefele, @padpadpadpad, and @revilodarnoc for their contributions to resolving this issue. Special thanks to @padpadpadpad for providing the helpful test audio.

@mbsantiago mbsantiago linked an issue Nov 11, 2024 that may be closed by this pull request
@mbsantiago mbsantiago merged commit c5c9476 into main Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest numpy results in error when detecting bat calls
1 participant