Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for users with no youtube app #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idangozlan
Copy link
Contributor

Added support for users with no youtube app
Handle of error callback is required to solve cases that user has no youtube app

Added support for users with no youtube app
Handle of error callback is required to solve cases that user has no youtube app
@macdonst
Copy link
Owner

Rather than call the error callback why don't we redirect the user to the Google Play store page for the YouTube app?

@idangozlan
Copy link
Contributor Author

lets give the developer to handle this case. we cant decide for the
developers..

in my case, i prefer to open childbrowser.
On Jan 11, 2013 9:52 PM, "macdonst" notifications@github.com wrote:

Rather than call the error callback why don't we redirect the user to the
Google Play store page for the YouTube app?


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-12160565.

@idangozlan
Copy link
Contributor Author

?
what are you saying?
i think we should treat this bug asap..

On Jan 11, 2013, at 9:56 PM, Idan Gozlan idangozlan@gmail.com wrote:

lets give the developer to handle this case. we cant decide for the developers..

in my case, i prefer to open childbrowser.

On Jan 11, 2013 9:52 PM, "macdonst" notifications@github.com wrote:
Rather than call the error callback why don't we redirect the user to the Google Play store page for the YouTube app?


Reply to this email directly or view it on GitHub.

@macdonst
Copy link
Owner

Check my latest commit to see what I mean.

5bf635f

@akamensky
Copy link

@macdonst Some vendors do not include Google applications to their firmware. Means, well, no matter how many times you try to redirect users of such devices to Play Google, they will never get the YouTube app from there simply because they don't have Google Play app, nor Google account option. Hence i somehow prefer option not involving YouTube app.

@surfjedi
Copy link

I am trying to use this on a standalone app that wonthave internet access or youtube app. Is there an example of it running like this?

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants