Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMD for FD spline weight calculation #123

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

yash-quark
Copy link
Contributor

@yash-quark yash-quark commented Sep 15, 2024

Pull request description:

Introduce SIMD at FD xsec weight calculation

Changes or fixes:

  • Add SIMD in splineFDBase::CalcSplineWeights()
  • Convert more couts/cerrs to loggers

Examples:

Event rate comparison after and before adding SIMD:

                  FHC1Rmu_2024 |         335.305 |         335.30518
                   FHC1Re_2024 |         88.7405 |         88.74053
             FHCnumuCC1pi_2024 |          127.01 |         127.00952
              FHCnueCC1pi_2024 |         18.1957 |         18.19566
                  RHC1Rmu_2024 |         130.034 |         130.03405
                   RHC1Re_2024 |         15.9463 |         15.94626

I see that the event rates are now rounded off, but not entirely sure if this comes from SIMD or some set precision command.

@yash-quark yash-quark added Enhancement New feature or request Tidy Minor code tidy labels Sep 15, 2024
@github-actions github-actions bot added Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples labels Sep 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your first PR, thank you for contributing to MaCh3!

@KSkwarczynski KSkwarczynski merged commit da7b1fa into develop Sep 18, 2024
8 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_SIMDatFD branch September 18, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Nu Osc/Xsec Related with neutrino interactions or oscialtions Samples Tidy Minor code tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants