Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Group #125

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Parameter Group #125

merged 5 commits into from
Sep 19, 2024

Conversation

KSkwarczynski
Copy link
Member

Pull request description:

Previosly we had this hardcoding isFlux etc. Which was quite bad... For some time in T2K we store ND syst params in Cov Xsec, this make seprate operations on ND Syst quite annoing. With new approach it should be much easier to Fix only ND Syst etc.

Changes or fixes:

  • Introduce parmater group
  • Remove isFlux etc

Examples:

image

@KSkwarczynski KSkwarczynski self-assigned this Sep 18, 2024
@github-actions github-actions bot added Nu Osc/Xsec Related with neutrino interactions or oscialtions Cmake labels Sep 18, 2024
@github-actions github-actions bot added Documentation Improvements or additions to documentation Plotting plotting related MCMC MCMC related Manager labels Sep 18, 2024
@KSkwarczynski KSkwarczynski merged commit 40ed805 into develop Sep 19, 2024
8 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_ParamGroup branch September 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmake Documentation Improvements or additions to documentation Manager MCMC MCMC related Nu Osc/Xsec Related with neutrino interactions or oscialtions Plotting plotting related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant