Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a "first" rel is not specified in a Link header, the "first" button links to a literal null value. #293

Closed
machawk1 opened this issue Nov 11, 2019 · 1 comment · Fixed by #295
Labels

Comments

@machawk1
Copy link
Owner

In #292, a "first" button is shown. Clicking this sends the user to https://matkelly.com/null. This is due to the Link header for this URI-R/URI-M (which in this case is one-in-the-same) of

Link: <http://matkelly.com/>; rel="original", <http://matkelly.com/archive/mkdc.tm>; rel="timemap"; type="application/link-format"

Note the lack of "first".

@machawk1 machawk1 added the bug label Nov 11, 2019
@machawk1
Copy link
Owner Author

This seems to be the result of the "first" button not being disabled by default in the HTML and not-so-much it being enabled:

<button id="memento_first" >First</button>
<button id="memento_prev" disabled>Previous</button>
&nbsp;&bull;&nbsp;
<button id="memento_next" disabled>Next</button>
<button id="memento_last" disabled>Last</button>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant