Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet cli build pipeline and AppVeyor CI pipeline #294

Merged
merged 8 commits into from
Jul 26, 2016

Conversation

ivanz
Copy link
Contributor

@ivanz ivanz commented Jul 25, 2016

This pull request achieves:

  • Build pipeline based on dotnet cli: currently side by side with the sln+csproj
  • Sets up build+test+nuget packaging pipeline in AppVeyor
  • AppVeyor is also integrated in checking new pull requests

All tests pass 👍 , so that should give me a good foundation to start introducing the .Net Standard targets.

Couple of notes:

  • The framework targets in the build pipeline are: .NET 3.5, 4.0, 4.5, 4.6
  • I haven't created xproj yet, because Visual Studio 2015 doesn't handle project.json without a .NET Standard/Core framework target, but that will be a non-issue once I start porting.

Working towards #280

I will keep the ruby+sln+csproj+msbuild stuff for now until the following two issues are resolved (should not block merging this in):

@ivanz ivanz force-pushed the feature/dotnet-cli-build branch from 890bb1a to e7248ac Compare July 25, 2016 16:53
@ivanz ivanz changed the title Feature/dotnet cli build dotnet cli build pipeline and AppVeyor CI pipeline Jul 25, 2016
@ivanz ivanz added this to the 0.10.0 ".Net Core / .Net Standard" support milestone Jul 25, 2016
@ivanz ivanz force-pushed the feature/dotnet-cli-build branch from e7248ac to 0ffc81e Compare July 25, 2016 17:13
@ivanz ivanz force-pushed the feature/dotnet-cli-build branch 2 times, most recently from 5f0e0da to 713aa78 Compare July 25, 2016 17:45
@ivanz ivanz force-pushed the feature/dotnet-cli-build branch from 713aa78 to b27bf34 Compare July 25, 2016 17:48
@ivanz
Copy link
Contributor Author

ivanz commented Jul 25, 2016

@einari In case you want to have a review of this 👍

@einari
Copy link
Contributor

einari commented Jul 26, 2016

Looks good. Added an issue (#295) for the future. I can probably look into that a bit later. Do the honors of merging.. 👍

@ivanz ivanz mentioned this pull request Jul 26, 2016
16 tasks
@ivanz ivanz merged commit 989166a into machine:develop Jul 26, 2016
@ivanz ivanz deleted the feature/dotnet-cli-build branch July 26, 2016 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants