-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet cli build pipeline and AppVeyor CI pipeline #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getting compiled..
…r to avoid non .Net Standard dependency.
…w targeting .Net 3.5+
890bb1a
to
e7248ac
Compare
e7248ac
to
0ffc81e
Compare
….NET-only. Next step is to prepare the CI for .NET
…ild everything and run all tests or in AppVeyor.
5f0e0da
to
713aa78
Compare
713aa78
to
b27bf34
Compare
@einari In case you want to have a review of this 👍 |
Looks good. Added an issue (#295) for the future. I can probably look into that a bit later. Do the honors of merging.. 👍 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request achieves:
dotnet cli
: currently side by side with the sln+csprojAll tests pass 👍 , so that should give me a good foundation to start introducing the .Net Standard targets.
Couple of notes:
Working towards #280
I will keep the ruby+sln+csproj+msbuild stuff for now until the following two issues are resolved (should not block merging this in):