onChange blocked

[PaddyMann]

Setting an onChange config option has no effect.

Could be fixed by adding a line to selectize.js config.onChange:

      config.onChange = function(value){
        if( !angular.equals(selectize.items, scope.ngModel) )
          scope.$evalAsync(function(){
            var value = angular.copy(selectize.items);
            if (config.maxItems == 1) {
              value = value[0]
            }
            modelCtrl.$setViewValue( value );
          });
        scope.config.onChange(value);
      }

For some reason my onChange function now gets called twice. Better than not at all though....

[PaddyMann]

Here's a better solution that doesn't call onChange twice:

      config.onChange = function(){
        if( !angular.equals(selectize.items, scope.ngModel) )
          scope.$evalAsync(function(){
            var value = angular.copy(selectize.items);
            if (config.maxItems == 1) {
              value = value[0]
            }

            if(modelCtrl.$viewValue != value) {
              modelCtrl.$setViewValue( value );
              scope.config.onChange(value);
            }
          });
      }

[machineboy2045]

Why not use a $watch() statement in your angular controller?

[PaddyMann]

I could have, but I assumed all of the config options to work and would have saved a couple of hours of headscratching had I known the of the issue :)

I was going to add that adding a $watch to the $digest cycle for each selectize input isn't ideal either, but then I'm unsure how that compares performance-wise with this implementation.

[gottfrois]

+1 on this, same issue, onChange called twice

[donpinkus]

+1 also seeing onChance called twice

sounds like we should just watch the model for now

[geemang2000]

+1 onChange does nothing, should expose same events as selectize

[geemang2000]

Nor does onInitialize

[geemang2000]

For what it's worth, the ng-change directive seems to work.

ng-change="change(app.settings)"

[miketeix]

+1 onChange is being called twice

[andrewdelprete]

+1 onChange is being called twice

[Uelb]

+1 onChange is being called twice

[andrewdelprete]

👏

[PhiLhoSoft]

As I wrote as comment to your commit (but I feel it belongs more here), I think you still need to set the silent flag to the setValue calls. Not only it prevents unnecessary calls (minor), but it also fixes the double call to onChange in the case of single selection mode.