quartodoc is not compatible w/ pydantic v2

[schloerke]

https://docs.pydantic.dev/2.0/migration/#migration-guide

Related:

quartodoc/quartodoc/layout.py

Lines 227 to 236 in 1375929

	class _AutoDefault(_Base):
	"""This hacky class allows creating Auto as a default option in Pages and Sections."""
	__root__: Union[str, dict]
	def __new__(cls, __root__: Union[str, dict]):
	if isinstance(__root__, dict):
	return Auto(**__root__)
	return Auto(name=__root__)

[machow]

Ah, thanks! It seems pretty tricky to implement root so it's compatible with pydantic v1 and v2 😅. I tried an implementation on this PR, but am now running into another error...

#211

TypeError: `discriminator` can only be used with `Union` type with more than one variant

Seems to occure when Page.update_forward_refs() gets called....

[machow]

I wonder if pydantic v2 expects that if there is a discriminator in a Union, then the other elements in the union must also be discriminators?

We have this piece of code...

ContentElement = Annotated[
    Union[Page, Section, Interlaced, Text, Auto], Field(discriminator="kind")
]
"""Entry in the contents list."""

ContentList = list[Union[ContentElement, Doc, _AutoDefault]]

Since Doc and _AutoDefault are just normal pydantic models, maybe it is considering each of them as Unions with only 1 variant?

edit: I tinkered a bit more and am pretty stumped

[machow]

Looks like it's this pydantic issue, and resolved in main a couple days ago:

pydantic/pydantic#6339

[eitsupi]

Any update on this?
I was going to start using quartodoc but cannot install it because of this problem.

[mlysy]

From the pydantic README section Pydantic V1.10 vs. V2:

Pydantic V2 also ships with the latest version of Pydantic V1 built in so that you can incrementally upgrade your code base and projects: from pydantic import v1 as pydantic_v1.

Might it be a worthwhile first step to just keep the needed bits from V1 until a fully V2 solution is found?

[machow]

Oh wow -- I don't know how I missed that, but it seems like a very quick fix, thanks! Given this is way less effort than I was planning, I'll work on making the change this week..!

[machow]

This should be resolved in https://github.com/machow/quartodoc/releases/tag/v0.6.4 (thanks to the tip above!)