Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not exclude child methods on alias classes #327

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

machow
Copy link
Owner

@machow machow commented Jan 19, 2024

Addresses #317 by ensuring we include methods defined in a class, even we are documenting an alias of that class.

@machow
Copy link
Owner Author

machow commented Jan 19, 2024

@has2k1 do you mind taking a look, to see if this fixes the issue for you? (Thanks for raising, it seems like a pretty serious bug).

@has2k1
Copy link
Contributor

has2k1 commented Feb 14, 2024

Yes this fixes the issue. It took a while to confirm as there were confounding issues that are in griffe and have been filed there.

@ecomodeller
Copy link

👍 This PR was exactly was I was looking for.

Have been scratching my head for some hours on trying to figure out why methods on my classes were not being rendered.

I can verify that it works for my examples as well. :shipit:

@machow
Copy link
Owner Author

machow commented Feb 14, 2024

Thanks for double checking!

@machow machow marked this pull request as ready for review February 14, 2024 17:01
@machow machow merged commit d4140b4 into main Feb 14, 2024
6 checks passed
@ecomodeller
Copy link

Hi @machow any plans to release a new version soon of quartodoc, I use this feature and would prefer to install a numbered version instead of a git hash? 🙏

@machow
Copy link
Owner Author

machow commented Jun 3, 2024

Hey, sorry for the wait--this is now released as v0.7.3. I'm planning a round of improvements, so if you've run into any issues in the meantime, definitely let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants