Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: get_object returns annotations from pyi stub files #360

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

machow
Copy link
Owner

@machow machow commented Aug 22, 2024

This PR verifies that quartodoc loads type annotations from stub files (.pyi) when present. Note that this may require a specific version of griffe, like v1+ (which is doing all the heavy lifting ;)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (81cccdf) to head (fcf7691).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   88.49%   88.51%   +0.01%     
==========================================
  Files          37       37              
  Lines        2843     2846       +3     
==========================================
+ Hits         2516     2519       +3     
  Misses        327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow machow merged commit 92b86af into main Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants