Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass loaders to replace_docstring for parser options #365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

machow
Copy link
Owner

@machow machow commented Sep 11, 2024

Addresses #364, by passing in the griffe loader directly, rather than trying to pull parser options off the static object.

TODO:

  • pull out loader creation into parsers.py or utils.py, etc.. so easy to use in tests, no duplicated in blueprint
  • test the specific case of a docstring not being on the static object

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.45%. Comparing base (4739a4e) to head (9de6e0a).

Files with missing lines Patch % Lines
quartodoc/autosummary.py 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   88.46%   88.45%   -0.02%     
==========================================
  Files          37       37              
  Lines        2931     2936       +5     
==========================================
+ Hits         2593     2597       +4     
- Misses        338      339       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants