Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot at converting ember-concurrency-decorators to TypeScript using ember-cli-typescript, so that we get auto-generated
.d.ts
files for using the decorators.This is unfortunately not perfect, because:
TaskProperty
, because TypeScript doesn't yet allow decorators to change the type signature: Request: Class Decorator Mutation microsoft/TypeScript#4881 (comment)@ember-decorators/utils
ember-concurrency
: Add typedefinitions ember-concurrency#209This is why all of this is kinda ad-hoc and we need to
// @ts-ignore
in the tests.I also need to clean up a little. Everything looks even more messy now and my makeshift types for ember-concurrency suck. 😄