Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript types #18

Closed
wants to merge 7 commits into from
Closed

feat: typescript types #18

wants to merge 7 commits into from

Conversation

buschtoens
Copy link
Collaborator

This is a shot at converting ember-concurrency-decorators to TypeScript using ember-cli-typescript, so that we get auto-generated .d.ts files for using the decorators.

This is unfortunately not perfect, because:

This is why all of this is kinda ad-hoc and we need to // @ts-ignore in the tests.

I also need to clean up a little. Everything looks even more messy now and my makeshift types for ember-concurrency suck. 😄

@buschtoens buschtoens force-pushed the feat/typescript-types branch from 83a1509 to cae6603 Compare October 24, 2018 08:55
@buschtoens
Copy link
Collaborator Author

Rebased onto latest master. But the generated types suck. 😄
I'll revisit it.

@buschtoens
Copy link
Collaborator Author

Since stage 2 decorators are miles away from TS decorators API-wise, it does not make sense any more to convert this to TypeScript just yet. When decorators are properly supported in TS, I'll revisit this.

In the meantime, I've already provided as manually created index.d.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant