Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yielded Components render as Class instead of property #337

Open
ilovethebends opened this issue Dec 18, 2019 · 5 comments
Open

Yielded Components render as Class instead of property #337

ilovethebends opened this issue Dec 18, 2019 · 5 comments

Comments

@ilovethebends
Copy link

It seems that for glimmer emblem treats nested properties as classes.

% MyForm::MyFormGroup as |formGroup|
	%formGroup.label @name="Ed"

label gets compiled into a class instead of a property on formGroup

<MyForm::MyFormGroup as |formGroup|>
  <formGroup @name="Ed" class="label"></formGroup>
</MyForm::MyFormGroup>

The other issue I'm finding is that %formGroup.label @name="Ed" gets translated into a block component instead inline.

Thanks in advance!

@wmlele
Copy link

wmlele commented Apr 28, 2020

Is this dead?
It is a real shame because I like emblem, but not supporting glimmer components will make it kind of unusable.

@wmlele
Copy link

wmlele commented Apr 28, 2020

Added a PR #341

@dfriquet
Copy link

I'd be glad to see this issue resolved too. For now, we need to jungle between .emblem and .hbs depending on the use of yielded components or not in the template. And I really miss Emblem's elegance when writing those Handlebars files…

Thanks @wmlele, this PR of yours looks pretty good!

@kjhangiani
Copy link

@thec0keman @machty any chance of getting this merged in?

@dfriquet
Copy link

dfriquet commented Dec 4, 2020

@thec0keman @machty Any chance you take a look at this issue in a near future?

@wmlele @kjhangiani Are you using some other fork of EmblemJS in production or have you thrown EmblemJS away altogether?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants