Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dots in glimmer component names #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wmlele
Copy link

@wmlele wmlele commented Apr 28, 2020

Primitive? attempt, looks ok for my purpose.

@kjhangiani
Copy link

the test should actually return <comp.name @value1={{foo}}/> rather than <comp.name @value1={{foo}}></comp.name> since its not used in a block context - will need to support both block and non-block contextual components

@wmlele
Copy link
Author

wmlele commented Jul 1, 2020

I agree, and l believe that is the subject of #338. Unfortunately that seems to be less trivial to fix than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants