Avoid pointer casting #8
Conversation
| } | ||
|
|
||
| #[inline] | ||
| unsafe fn rebuild(mut ptr: NonNull<Self>, capacity: usize) -> String { | ||
| unsafe fn owned_from_parts(mut ptr: NonNull<Self>, capacity: NonZeroUsize) -> String { | ||
| String::from_utf8_unchecked(Vec::from_raw_parts( | ||
| ptr.as_mut().as_mut_ptr(), |
There was a problem hiding this comment.
This should probably be ptr.cast::<u8>().as_raw() to avoid manifesting (and deriving from) a temporary borrow.
There was a problem hiding this comment.
Ended up reading about cast. TIL casting a fat pointer to a thin pointer is ok.
| Vec::from_raw_parts(ptr.as_mut().as_mut_ptr(), ptr.as_mut().len(), capacity) | ||
| unsafe fn owned_from_parts(mut ptr: NonNull<Self>, capacity: NonZeroUsize) -> Vec<T> { | ||
| Vec::from_raw_parts( | ||
| ptr.as_mut().as_mut_ptr(), |
There was a problem hiding this comment.
This should probably be ptr.cast::<T>().as_raw() to avoid manifesting (and deriving from) a temporary borrow.
| } | ||
|
|
||
| #[inline] | ||
| unsafe fn rebuild(mut ptr: NonNull<Self>, capacity: usize) -> String { | ||
| unsafe fn owned_from_parts(mut ptr: NonNull<Self>, capacity: NonZeroUsize) -> String { | ||
| String::from_utf8_unchecked(Vec::from_raw_parts( | ||
| ptr.as_mut().as_mut_ptr(), | ||
| ptr.as_mut().len(), |
There was a problem hiding this comment.
If I'm being overcautious, I'd bring the len call up before the as_mut_ptr, and do it as ptr.as_ref().len(). If you want to be super correct, you can write fn slice_len<T>(ptr: NonNull<[T]>) -> usize to just directly extract the length metadata today: https://discordapp.com/channels/273534239310479360/592856094527848449/688117580040241162
&mut T as *mut T.Beef::owned_ptris no longer marked asunsafe.