Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we teach object! to accept trailing commas #125

Closed
Yoric opened this issue Oct 4, 2017 · 3 comments
Closed

Could we teach object! to accept trailing commas #125

Yoric opened this issue Oct 4, 2017 · 3 comments

Comments

@Yoric
Copy link
Contributor

Yoric commented Oct 4, 2017

Right now,

object!{
  "foo" => "bar",
}

fails because of the trailing comma. It would be nicer to accept them, as in the rest of Rust.

@maciejhirsz
Copy link
Owner

Last time I tried it the macro layout wasn't very happy about it, but I will look into it again.

@Yoric
Copy link
Contributor Author

Yoric commented Oct 6, 2017

I can give it a try this week-end, if you want.

@maciejhirsz
Copy link
Owner

Sure, always happy to accept contributions. I'm currently swarmed with work.

Yoric added a commit to Yoric/json-rust that referenced this issue Oct 7, 2017
maciejhirsz added a commit that referenced this issue Oct 7, 2017
Resolves #125 - Accept trailing commas in object!{}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants