Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should JsonError and JsonResult just be Error and Result? #38

Closed
zummenix opened this issue Jun 28, 2016 · 3 comments · Fixed by #72
Closed

Should JsonError and JsonResult just be Error and Result? #38

zummenix opened this issue Jun 28, 2016 · 3 comments · Fixed by #72

Comments

@zummenix
Copy link
Contributor

I'm not sure about JsonValue.

@maciejhirsz
Copy link
Owner

I'm not sure what the consensus of the community is about those, I personally like avoiding the confusion with built in Result type and Error trait.

Gonna leave this up for a discussion, and maybe look up what other major crates are doing.

@gsquire
Copy link

gsquire commented Jul 4, 2016

I think it's quite common to define library specific error and result types. For example the standard library uses io::Error and io::Result for IO operations. It allows for less ambiguous types.

@maciejhirsz
Copy link
Owner

Following standard library in that regard might be a good idea. Since renaming stuff can be a breaking change, I'd schedule it for 0.9.0.

@maciejhirsz maciejhirsz added this to the 0.9.0 milestone Jul 5, 2016
maciejhirsz added a commit that referenced this issue Jul 7, 2016
respectively #38
- Implement `take` and `take_string` on `JsonValue`
@maciejhirsz maciejhirsz mentioned this issue Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants