Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IntoIterator for Object. #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timothee-haudebourg
Copy link

This a proposition of implementation of IntoIter for Object (#190). I also added an implementation of From<Key> for String to take ownership of the key, although the optimization for small strings is lost during the conversion.

Normally I would advocate using a crate such as smallstring to take care of the optimization for you, so that the IntoIter iterator can yield items of type (SmallString, JsonValue), but the crate seems abandoned...

@gierens
Copy link

gierens commented Aug 25, 2023

Since this project is unmaintained, I forked to https://github.com/rustadopt/jzon-rs where I for example merged this PR and maintain it from now on with the community. It's also available in v0.12.5 on https://crates.io/crates/jzon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants