reorganized and compressed tests for bugs

test/java/org/quackery/contract/Bugs.java

@@ -0,0 +1,24 @@
+package org.quackery.contract;
+
+import static java.util.Arrays.asList;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public class Bugs {
+  public static List<Class<?>> bugs(Class<?> model, Class<?>... contract) {
+    List<Class<?>> bugs = new ArrayList<>();
+    for (Class<?> bug : model.getDeclaredClasses()) {
+      if (unorderedEquals(bug.getAnnotation(Bug.class).value(), contract)) {
+        bugs.add(bug);
+      }
+    }
+    return bugs;
+  }
+
+  private static <T> boolean unorderedEquals(T[] arrayA, T[] arrayB) {
+    List<T> listA = asList(arrayA);
+    List<T> listB = asList(arrayB);
+    return listA.containsAll(listB) && listB.containsAll(listA);
+  }
+}

test/java/org/quackery/contract/collection/MutableList.java

@@ -12,7 +12,7 @@
 
 import org.quackery.contract.Bug;
 
-public class MutableList<E> implements Mutable, List<E> {
+public class MutableList<E> implements List<E> {
   protected List<E> delegate;
 
   public MutableList() {

test/java/org/quackery/contract/collection/test_MutableList.java

@@ -0,0 +1,65 @@
+package org.quackery.contract.collection;
+
+import static org.quackery.Contracts.quacksLike;
+import static org.quackery.contract.Bugs.bugs;
+import static org.quackery.testing.Assertions.assertFailure;
+import static org.quackery.testing.Assertions.assertSuccess;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+import org.quackery.Contract;
+
+public class test_MutableList {
+  private final Class<?> model = MutableList.class;
+  private Contract<Class<?>> contract;
+
+  public void quacks_like_collection() {
+    contract = quacksLike(Collection.class);
+    assertSuccess(contract.test(model));
+    for (Class<?> bug : bugs(model, Collection.class)) {
+      assertFailure(contract.test(bug));
+    }
+  }
+
+  public void quacks_like_mutable_collection() {
+    contract = quacksLike(Collection.class).mutable();
+    assertSuccess(contract.test(model));
+    for (Class<?> bug : join(
+        bugs(model, Collection.class),
+        bugs(model, Collection.class, Mutable.class))) {
+      assertFailure(contract.test(bug));
+    }
+  }
+
+  public void quacks_like_list() {
+    contract = quacksLike(List.class);
+    assertSuccess(contract.test(model));
+    for (Class<?> bug : join(
+        bugs(model, Collection.class),
+        bugs(model, List.class))) {
+      assertFailure(contract.test(bug));
+    }
+  }
+
+  public void quacks_like_mutable_list() {
+    contract = quacksLike(List.class).mutable();
+    assertSuccess(contract.test(model));
+    for (Class<?> bug : join(
+        bugs(model, Collection.class),
+        bugs(model, Collection.class, Mutable.class),
+        bugs(model, List.class),
+        bugs(model, List.class, Mutable.class))) {
+      assertFailure(contract.test(bug));
+    }
+  }
+
+  private static List<Class<?>> join(List<Class<?>>... parts) {
+    List<Class<?>> joined = new ArrayList<>();
+    for (List<Class<?>> part : parts) {
+      joined.addAll(part);
+    }
+    return joined;
+  }
+}

test/java/org/quackery/test_all.java

@@ -6,10 +6,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import org.quackery.contract.collection.test_contract_for_collection;
-import org.quackery.contract.collection.test_contract_for_collection_mutable;
-import org.quackery.contract.collection.test_contract_for_list;
-import org.quackery.contract.collection.test_contract_for_list_mutable;
+import org.quackery.contract.collection.test_MutableList;
 import org.quackery.contract.collection.test_detecting_alien_types;
 import org.quackery.contract.collection.test_jdk_collections;
 
@@ -21,10 +18,7 @@ public static void main(String[] args) throws Throwable {
     runTestsIn(test_Case.class);
     runTestsIn(test_Suite.class);
     runTestsIn(test_QuackeryRunner.class);
-    runTestsIn(test_contract_for_collection.class);
-    runTestsIn(test_contract_for_collection_mutable.class);
-    runTestsIn(test_contract_for_list.class);
-    runTestsIn(test_contract_for_list_mutable.class);
+    runTestsIn(test_MutableList.class);
     runTestsIn(test_detecting_alien_types.class);
     runTestsIn(test_jdk_collections.class);