Fix UB when there are no audio devices #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no capture nor playback devices, pContext->pDeviceInfos is NULL and pContext->playbackDeviceInfoCount is 0. Unfortunately, any arithmetic on NULL is UB, including trivial +0, which triggers UB sanitizer. This can lead to crashes, for example when compiling with Zig, which enables UBsan by default.
|
This is reasonable. Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no capture nor playback devices,
pContext->pDeviceInfosisNULLandpContext->playbackDeviceInfoCountis 0. Unfortunately, any arithmetic onNULLis UB, including trivial+0, which triggers UB sanitizer. This can lead to crashes, for example when compiling with Zig, which enables UBsan by default.Note: this could easily be a oneliner, but the line was already long enough.
I have also wanted to include an explicit comment, because without knowing that
NULL+0is UB, the code would seem insane.Some extra context: SO about NULL arithmetic and Zig issue about the same problem elsewhere.