Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SidebarItem): use theme's primary color instead of hardcoded value #374

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

GroovinChip
Copy link
Collaborator

Closes #313

Pre-launch Checklist

  • I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
  • I have added/updated relevant documentation
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could

@GroovinChip GroovinChip self-assigned this Feb 28, 2023
@github-actions
Copy link

Dart Code Metrics analyze report of macos_ui. ✅

Summary

  • Scanned folders: lib

  • Total scanned files: 75

  • Total lines of source code: 9105

  • Total classes: 189

  • Average Cyclomatic Number per line of code: 0.24 / 5

  • Average Source Lines of Code per method: 11

  • Total tech debt: not found

  • Found issues: 0 ✅

@GroovinChip GroovinChip merged commit 519a4f8 into dev Feb 28, 2023
@GroovinChip GroovinChip deleted the issue_313_fix branch February 28, 2023 21:57
GroovinChip added a commit that referenced this pull request Feb 28, 2023
* feat: Sliver toolbar (#368)

* feat: `SliverToolBar`

* chore(example): address lints

* docs(SliverToolbar): update `floating` doc

* feat(example): add page for SliverToolbar

* chore: dart format

* docs(SliverToolBar): slight change to `pinned` docs

* docs(SliverToolBar): add section to readme

* docs(SliverToolBar): tweak sample

* test(SliverAppBar): add initial tests

* chore: update version & changelog

* chore: pub upgrade

* chore: remove unused imports

* test: remove ignore lint

* fix(SidebarItem): use theme's primary color instead of hardcoded value  (#374)

* fix(SidebarItem): use theme's primary color instead of hardcoded value

Fixes #313

* chore: update version, changelog
@GroovinChip GroovinChip mentioned this pull request Mar 2, 2023
GroovinChip added a commit that referenced this pull request Apr 6, 2023
#374)

* fix(SidebarItem): use theme's primary color instead of hardcoded value

Fixes #313

* chore: update version, changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SideBarItem leading icon theme should respect configured theme
1 participant