Replace ToolBar with PreferredSizeWidget #477
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As per SOLID principles,
MacOsScaffold
'stoolBar
should be aPreferredSizeWidget
.The longer story.
Hello guys, hope you are well. I was going to write an app for MacOS. I have adopted this amazing library.
However, I have hit a wall with this scenario:
My
MainScreen
contains aMacOsScaffold
, which contains aToolBar
and many children:My
ToolBar
has many options, conditions and buttons, so I would like to create a separateWidget
to deal with those.However, the
MacosScaffold
doesn't accept anything else that is not aToolBar
.Other frameworks (e.g.
Material
) accepts aPreferredSizeWidget
, which allows me to writeAnd this solves my problem.
BONUS: this respect's Flutter's phylosophy of composition over inheritance.
Pre-launch Checklist
CHANGELOG.md
with my changes