Ruby 3.2 #392
Merged
Ruby 3.2 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests look to be flapping in master branch :( |
|
LGTM, thanks. The tests have been flaky since forever, feel free to fix them if you have the time/energy to figure out what is going wrong. |
|
I suggest releasing a new gem that unbreaks 3.2. |
thesamesam
added a commit
to thesamesam/gentoo
that referenced
this pull request
Mar 31, 2023
Backport an upstream patch for ruby32. It's not too big at least. I've also asked upstream if they'll consider making a new release. Bug: macournoyer/thin#392 Bug: macournoyer/thin#393
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 31, 2023
Backport an upstream patch for ruby32. It's not too big at least. I've also asked upstream if they'll consider making a new release. Bug: macournoyer/thin#392 Bug: macournoyer/thin#393 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes removed
File.exists?and couple deprecations that are not breaking yet