bazel: Update to version 0.9.0 #1098

missa-prime · 2017-12-10T22:11:22Z

Description

Closes: https://trac.macports.org/ticket/55407
Closes: https://trac.macports.org/ticket/55659

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.12.6
Xcode 9.2

Verification

Have you

followed our Commit Message Guidelines?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint?
tested basic functionality of all binary files?

mojca · 2017-12-11T06:36:23Z

devel/bazel/Portfile

+    file delete -force /var/tmp/_${name}_root
+    exec -ignorestderr -- git init ${worksrcpath}
+    exec -ignorestderr -- git add ${worksrcpath}
+    exec -ignorestderr -- git commit -m GitRepo


Why do you need to make a dummy commit during the build phase?

It also looks a bit suspicious that a build would fail if you don't remove a file.

Oddly enough, I can't build the bash completion script without deleting that temporary directory and having a local git repo in that state. I suspect it's a bug that popped up after 0.5.2. So essentially these changes work around that problem.

Never use exec, only system.

I don't understand why this would be necessary, though. If a git repo is assumed in any build rule, better patch that.

Why only system rather than exec? Also, could you point me to a good document for system? I'm not finding one online.

From man portfile:

system [-W dir] commandline Execute a program. See system(3). For calls to install(1) please use xinstall. For calls to mv(1), cp(1), rm(1) or similar, please use the built-in commands or file if they don't meet your requirements. -W Change to dir before working.

Without that bit of code, the bazel build errors out like this

Build successful! Binary is here: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_bazel/bazel/work/bazel-0.9.0-dist/output/bazel xinstall: chdir(/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_bazel/bazel/work/bazel-0.9.0-dist/output) xinstall: bazel -> /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_bazel/bazel/work/bazel-0.9.0-dist/bazel Extracting Bazel installation... ..................... Loading: Loading: 0 packages loaded Analyzing: target //scripts:bazel-complete.bash (3 packages loaded) Analyzing: target //scripts:bazel-complete.bash (4 packages loaded) Analyzing: target //scripts:bazel-complete.bash (73 packages loaded) Analyzing: target //scripts:bazel-complete.bash (75 packages loaded) Analyzing: target //scripts:bazel-complete.bash (195 packages loaded) INFO: Analysed target //scripts:bazel-complete.bash (195 packages loaded). INFO: Found 1 target... [0 / 2] [-----] BazelWorkspaceStatusAction stable-status.txt ERROR: Process exited with status 128: Process exited with status 128 fatal: Not a git repository (or any of the parent directories): .git Target //scripts:bazel-complete.bash failed to build INFO: Elapsed time: 25.182s, Critical Path: 0.14s FAILED: Build did NOT complete successfully FAILED: Build did NOT complete successfully Error: Failed to build bazel: child process exited abnormally Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_bazel/bazel/main.log for details. Error: Follow https://guide.macports.org/#project.tickets to report a bug. Error: Processing of port bazel failed

Anyway, with that bit of code in, 0.9.0 builds without intervention

$ port -v installed bazel The following ports are currently installed: bazel @0.9.0_0 (active) platform='darwin 17' archs='x86_64' date='2017-12-30T17:32:13-0800'

Thanks!

emcrisostomo · 2018-01-13T08:39:53Z

@RootFunction, if you take a look at #1132 you'll see that @kencu contributed an updated 0.9.0 Portfile inspired to yours. Would you please bump this PR to 0.9.0?

missa-prime · 2018-01-14T22:22:34Z

@emcrisostomo, I have bumped the PR to 0.9.0

@kencu, Switching from exec to system causes the installation to hang. I suspect the issue is in the bash completion script portion again. I think there is some gotcha I'm missing when using system in this case, but I'm not sure what.

emcrisostomo · 2018-01-14T23:01:58Z

Thank you @RootFunction.

kencu · 2018-01-15T00:00:08Z

Personally I could accept this as it is. There are other ports that use exec in the Ports tree. But there are requests to either find a way to use system or find a way to patch out the scripting that is calling for this in the first place. Patching out the scripting is over my head at present. When I get a minute I'll see if I can figure out a system -W call. Doesn't help that building bazel takes forever...

pmetzger · 2018-01-28T16:39:08Z

Should this be merged? @kencu ?

kencu · 2018-02-04T01:30:41Z

trying to find an afternoon to work on this...

kencu · 2018-02-08T20:26:44Z

I think I have the system -W calls all worked out.

There is still a huge pause in the build (think hour-long or more) while I-have-no-idea-what is happening.

INFO: From Executing genrule //scripts:bash_completion:
Extracting Bazel installation...
Target //scripts:bazel-complete.bash up-to-date:
  bazel-bin/scripts/bazel-complete.bash
INFO: Elapsed time: 747.894s, Critical Path: 85.57s
INFO: Build completed successfully, 1723 total actions
INFO: Build completed successfully, 1723 total actions

LONG PAUSE HERE

Seems this is something that happens sometimes when building things with bazel bazelbuild/bazel#748. No idea if it's fixable or not.

It may well cause the buildbots to all time out, tho, as there is no output during this pause, and top shows nothing much is doing anything.

I'll fix up the PR once I can confirm it all works as expected.

kencu · 2018-02-08T21:09:05Z

Still waiting. But I know from previous bazel builds it will likely finish. I have sampled all the current processes that have macports as a user, and I'll put these samples here in case some genius out there can see why this build is stuck

Sample of cfprefsd.txt
Sample of distnoted.txt
Sample of java1.txt
Sample of java2.txt
Sample of java3.txt
Sample of java4.txt
Sample of lsd.txt
Sample of tclsh8.5.txt

pmetzger · 2018-02-08T21:20:28Z

@kencu Have you tried tracing the process while the pause happens?

kencu · 2018-02-09T01:40:16Z

OK. As before, it sat paused for about two hours, and then finished successfully.

@pmetzger -- the traces are in the post just above yours.

I'll fix up the PR, and we can commit it. We'll see how many people cancel out the build and post tickets about the build failure :>

kencu · 2018-02-09T02:01:23Z

@RootFunction -- your PR is against your master branch, and I can't update it due to permissions.

Here is the commit message I had used (squashed):

commit 439fae2be6375e2014559de383e83136e4229bb3 (HEAD -> master)
Author: RootFunction <RootFunction@users.noreply.github.com>
Date:   Sun Dec 10 16:26:35 2017 -0500

    bazel: Update to version 0.9.0
    
    closes: https://trac.macports.org/ticket/55407
    closes: https://trac.macports.org/ticket/55731
    closes: https://trac.macports.org/ticket/55736

and here is the diff against the current MacPorts master branch:

bazelfix.diff.txt

kencu · 2018-02-12T02:45:14Z

So this PR looks good to go to me, if those changes are made in @RootFunction 's PR. I can't do it like I usually might, due to the PR being made off the master branch. So you'll have to do it in your PR, and then squash the commits down to one commit.

kencu · 2018-02-14T18:58:25Z

@RootFunction -- would you like me to just push this from my own repo, and close this PR?

pmetzger · 2018-02-14T19:19:25Z

@kencu Why don't you just do that? It would be quick.

closes: https://trac.macports.org/ticket/55407 closes: https://trac.macports.org/ticket/55731 closes: https://trac.macports.org/ticket/55736 see #1098

kencu · 2018-02-14T22:08:48Z

committed separately c47cd8d

kencu · 2018-02-15T01:01:32Z

Hmmm. That didn't work out as planned. Build failed on every system....oops.

The error is

DEBUG: Executing org.macports.build (bazel)
DEBUG: system -W /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_bazel/bazel/work/bazel-0.9.0-dist: ./compile.sh

ERROR: Could not find JAVA_HOME, please ensure a JDK (version 1.8+) is installed.
Command failed: ./compile.sh
Exit code: 1

kencu · 2018-02-15T07:10:35Z

And that would be because Java isn't installed on any of the buildbots, I understand. So all is likely OK after all.

missa-prime · 2018-02-18T23:00:46Z

Thanks @kencu for all the work to close this. After giving this a try, I was a little worried when it didn't finish after 2 hours. I decided to stick with it though, and everything finished after 4 hours on my machine.

kencu · 2018-02-19T02:41:08Z

It's a totally nutty long delay. Just for my knowledge, is that bash completion script so useful that it has to be built? Things would go much smoother without it!!

Maybe somebody will see something in those traces I posted and come up with the proper fix for this...

missa-prime · 2018-02-21T04:18:39Z

If this was a new port, I would suggest leaving the completion script out to keep the installation time sane. It could then be re-introduced during a later update or the user could build and install manually if truly needed.

Anyway, I've opened bazelbuild/bazel#4670 and bazelbuild/bazel#4671 to track all the problems encountered in this PR.

bazel: Update port, version 0.8.1

04e43de

macportsbot added maintainer maintainer: open Affects an openmaintainer port type: enhancement type: update labels Dec 10, 2017

mojca reviewed Dec 11, 2017

View reviewed changes

kencu mentioned this pull request Jan 9, 2018

bazel: update to 0.9.0 #1132

Closed

10 tasks

bazel: Update port, version 0.9.0

a7fee49

missa-prime changed the title ~~bazel: Update to version 0.8.1~~ bazel: Update to version 0.9.0 Jan 14, 2018

kencu added a commit that referenced this pull request Feb 14, 2018

bazel: Update to version 0.9.0

c47cd8d

closes: https://trac.macports.org/ticket/55407 closes: https://trac.macports.org/ticket/55731 closes: https://trac.macports.org/ticket/55736 see #1098

kencu closed this Feb 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bazel: Update to version 0.9.0 #1098

bazel: Update to version 0.9.0 #1098

missa-prime commented Dec 10, 2017 •

edited

Loading

mojca Dec 11, 2017

missa-prime Dec 11, 2017

raimue Dec 11, 2017

missa-prime Dec 12, 2017

l2dy Dec 12, 2017

kencu Dec 31, 2017

kencu Dec 31, 2017

emcrisostomo commented Jan 13, 2018

missa-prime commented Jan 14, 2018

emcrisostomo commented Jan 14, 2018

kencu commented Jan 15, 2018

pmetzger commented Jan 28, 2018

kencu commented Feb 4, 2018

kencu commented Feb 8, 2018

kencu commented Feb 8, 2018

pmetzger commented Feb 8, 2018

kencu commented Feb 9, 2018

kencu commented Feb 9, 2018

kencu commented Feb 12, 2018

kencu commented Feb 14, 2018

pmetzger commented Feb 14, 2018

kencu commented Feb 14, 2018

kencu commented Feb 15, 2018 •

edited

Loading

kencu commented Feb 15, 2018

missa-prime commented Feb 18, 2018

kencu commented Feb 19, 2018

missa-prime commented Feb 21, 2018

bazel: Update to version 0.9.0 #1098

bazel: Update to version 0.9.0 #1098

Conversation

missa-prime commented Dec 10, 2017 • edited Loading

Description

Type(s)

Tested on

Verification

mojca Dec 11, 2017

Choose a reason for hiding this comment

missa-prime Dec 11, 2017

Choose a reason for hiding this comment

raimue Dec 11, 2017

Choose a reason for hiding this comment

missa-prime Dec 12, 2017

Choose a reason for hiding this comment

l2dy Dec 12, 2017

Choose a reason for hiding this comment

kencu Dec 31, 2017

Choose a reason for hiding this comment

kencu Dec 31, 2017

Choose a reason for hiding this comment

emcrisostomo commented Jan 13, 2018

missa-prime commented Jan 14, 2018

emcrisostomo commented Jan 14, 2018

kencu commented Jan 15, 2018

pmetzger commented Jan 28, 2018

kencu commented Feb 4, 2018

kencu commented Feb 8, 2018

kencu commented Feb 8, 2018

pmetzger commented Feb 8, 2018

kencu commented Feb 9, 2018

kencu commented Feb 9, 2018

kencu commented Feb 12, 2018

kencu commented Feb 14, 2018

pmetzger commented Feb 14, 2018

kencu commented Feb 14, 2018

kencu commented Feb 15, 2018 • edited Loading

kencu commented Feb 15, 2018

missa-prime commented Feb 18, 2018

kencu commented Feb 19, 2018

missa-prime commented Feb 21, 2018

missa-prime commented Dec 10, 2017 •

edited

Loading

kencu commented Feb 15, 2018 •

edited

Loading