Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoarVM, nqp, rakudo: update to 2022.04 #14932

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented May 24, 2022

Description

Updates MoarVM, nqp, rakudo to the latest 2022.04 versions.

Add minor fixes for ppc build for MoarVM. Submitted to the upstream, so hopefully patches can be dropped in the next update.

  1. Undefined AI_NUMERICSERV: I encountered this error on 10.6, however it has been also reported on Windows: src/io/syncsocket.c:287:38: error: 'AI_NUMERICSERV' undeclared (first use in this function) MoarVM/MoarVM#1704 (comment)
    PR: Add definition of AI_NUMERICSERV, fixes build on MacOS 10.6 for ppc MoarVM/MoarVM#1705
  2. dyncall configure should have Rosetta case, and original repo actually has it, but MoarVM lost it on the way. PR: dyncall: add 10.6 Rosetta case to configure MoarVM/dyncall#10
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 Server
Xcode 3.2.6

macOS 10.6 PPC (10A190)
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@mojca for port MoarVM, nqp, rakudo.

@barracuda156
Copy link
Contributor Author

P. S. Re typography commit: it is not just a matter of æsthetics to have “it’s” and not “it's”; in BBEdit the latter creates a havoc with text coloring used in standard language modules (that of Tcl, in this case).

@barracuda156
Copy link
Contributor Author

Rosetta still need blacklisting clang (only Rosetta, not 10.6 PPC:

--->  Building MoarVM
Executing:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_lang_MoarVM/MoarVM/work/MoarVM-2022.04" && /usr/bin/make -j4 -w all 
make: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_lang_MoarVM/MoarVM/work/MoarVM-2022.04'
compiling src/main.o
compiling src/core/callsite.o
compiling src/core/args.o
clang: warning: not using the clang compiler for the 'powerpc' architecture
compiling src/core/exceptions.o
clang: warning: not using the clang compiler for the 'powerpc' architecture
clang: warning: not using the clang compiler for the 'powerpc' architecture
clang: warning: not using the clang compiler for the 'powerpc' architecture
cc1: error: -Werror=vla: No option -Wvla
cc1: error: unrecognized command line option "-Wno-logical-op-parentheses"
cc1: error: -Werror=vla: No option -Wvla
cc1: error: -Werror=vla: No option -Wvla
cc1: error: unrecognized command line option "-Wno-logical-op-parentheses"
cc1: error: unrecognized command line option "-Wno-logical-op-parentheses"
make: *** [src/core/args.o] Error 1
make: *** Waiting for unfinished jobs....
cc1: error: -Werror=vla: No option -Wvla
cc1: error: unrecognized command line option "-Wno-logical-op-parentheses"
make: *** [src/core/callsite.o] Error 1
make: *** [src/main.o] Error 1
make: *** [src/core/exceptions.o] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_lang_MoarVM/MoarVM/work/MoarVM-2022.04'
Command failed:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_lang_MoarVM/MoarVM/work/MoarVM-2022.04" && /usr/bin/make -j4 -w all 
Exit code: 2
Error: Failed to build MoarVM: command execution failed

@barracuda156
Copy link
Contributor Author

barracuda156 commented May 24, 2022

@mojca @mascguy What’s your opinion on blacklisting clang either for platform darwin powerpc (anyway it is broken there) or specifically for 10.6 when building for ppc? I won’t really insist, if there are objections. But it is an easy fix for Rosetta which won’t affect anyone else.

With gcc it builds nicely on 10.6.8 for ppc:

macmini:~ svacchanda$ sw_vers
ProductName:	Mac OS X Server
ProductVersion:	10.6.8
BuildVersion:	10K549
macmini:~ svacchanda$ port -v installed MoarVM
The following ports are currently installed:
  MoarVM @2022.02_0 requested_variants='' platform='darwin 10' archs='ppc' date='2022-03-28T15:58:12+0800'
  MoarVM @2022.04_0 (active) requested_variants='' platform='darwin 10' archs='ppc' date='2022-05-24T21:37:35+0800'

@mascguy
Copy link
Member

mascguy commented May 24, 2022

@mojca @mascguy What’s your opinion on blacklisting clang either for platform darwin powerpc (anyway it is broken there) or specifically for 10.6 when building for ppc? I won’t really insist, if there are objections. But it is an easy fix for Rosetta which won’t affect anyone else.

I'm not opposed to the idea, but I'll defer to others.

@barracuda156
Copy link
Contributor Author

@mascguy @mojca Do we have any issues with this PR to fix?

@mojca
Copy link
Member

mojca commented Jun 2, 2022

I'm sorry, I forgot to reply. The PR looks perfectly fine to me.

@mojca
Copy link
Member

mojca commented Jun 2, 2022

I believe that it should be perfectly ok to blacklist clang for all ppcs. Was clang ever even functional?

@barracuda156
Copy link
Contributor Author

I believe that it should be perfectly ok to blacklist clang for all ppcs. Was clang ever even functional?

No, it was and remains broken for PPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants