Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: update to 3.5.2 #15241

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Knapoc
Copy link
Contributor

@Knapoc Knapoc commented Jun 29, 2022

Description

nextcloud-client: update to 3.5.1

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.4 21F79 x86_64
Xcode 13.4.1 13F100

Verification

Have you

@Knapoc Knapoc force-pushed the nextcloud-client-3.5.1 branch 3 times, most recently from 96db4a1 to b46f2bd Compare June 29, 2022 21:09
@mascguy mascguy force-pushed the nextcloud-client-3.5.1 branch from b46f2bd to e02be1f Compare July 11, 2022 19:00
@mascguy mascguy requested a review from ra1nb0w July 11, 2022 19:15
@mascguy

This comment was marked as outdated.

@mascguy mascguy force-pushed the nextcloud-client-3.5.1 branch from e02be1f to 6b4285f Compare July 11, 2022 19:48
@mascguy mascguy changed the title nextcloud-client: update to 3.5.1 nextcloud-client: update to 3.5.2 Jul 11, 2022
@mascguy
Copy link
Member

mascguy commented Jul 11, 2022

Upstream has released 3.5.2, and it appears to now include the build fix for macOS releases prior to Big Sur. (With the caveat that it only supports 10.14 and later.)

nextcloud/desktop#4557

However, based on a quick local test build, I'm still seeing failures for 10.15.

@ra1nb0w Does the fix work for you, assuming you have a 10.14 or 10.15 installation...?

Updated patch to use a preprocessor block, rather than a runtime check via available(). Also commented on upstream's issue/commit, to let them know.

@mascguy mascguy force-pushed the nextcloud-client-3.5.1 branch from 6b4285f to 39c50b7 Compare July 11, 2022 19:52
@mascguy mascguy self-assigned this Jul 11, 2022
@mascguy mascguy merged commit 34f0111 into macports:master Jul 11, 2022
@Knapoc Knapoc deleted the nextcloud-client-3.5.1 branch July 11, 2022 21:13
@ra1nb0w
Copy link
Contributor

ra1nb0w commented Jul 12, 2022

sorry, I was away. thank you @mascguy

@mascguy
Copy link
Member

mascguy commented Jul 12, 2022

FYI, upstream has opened the following issue, per my suggested change: nextcloud/desktop#4720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants