Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbcsr: fix linking to vecLibFort, fix tests on old systems #17394

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

barracuda156
Copy link
Contributor

Signed-off-by: Sergey Fedorov vital.had@gmail.com

Description

@herbygillot I hope with this one dbcsr gonna be fixed for now. I have made all tests pass, no more failures: cp2k/dbcsr#645 (comment)

Sorry, in the last PR I dropped configure args, wrongly assuming that PG handles it. It does not: https://trac.macports.org/ticket/66714

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 Server
Xcode 3.2.6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156 barracuda156 marked this pull request as draft January 19, 2023 22:18
@barracuda156
Copy link
Contributor Author

barracuda156 commented Jan 19, 2023

Haha, now Clang failing. Okay, this time we have to fix it properly. Gimme a bit.

UPD. PG chooses OpenBLAS on these systems, but passes only -DBLA_VENDOR=OpenBLAS, which is not recognized. I will fix it now.

Signed-off-by: Sergey Fedorov <vital.had@gmail.com>
@barracuda156
Copy link
Contributor Author

barracuda156 commented Jan 19, 2023

@herbygillot Looks good now. Finally :)

UPD. And the last thing, added blacklist of {clang < 500}, it fails on 10.7: https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/130314/steps/install-port/logs/stdio

@barracuda156 barracuda156 marked this pull request as draft January 20, 2023 07:00
@barracuda156
Copy link
Contributor Author

I am done with this :)

@herbygillot herbygillot merged commit c389b77 into macports:master Jan 20, 2023
@barracuda156 barracuda156 deleted the dbcsr branch January 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants