aircrack-ng: add patch for arm64 #19307
Conversation
|
Notifying maintainers: |
macportsbot
added
type: enhancement
maintainer: open
security/aircrack-ng/Portfile
Outdated
| if {${configure.build_arch} eq "arm64"} { | ||
| patchfiles-append \ | ||
| patch-psedo_intrinsics.patch | ||
| } |
There was a problem hiding this comment.
Is there any reason not to apply this patch unconditionally?
Applying conditionally based on build_arch will not do the right thing when the universal variant is used.
Is this patch known to upstream? Is there an upstream PR or bug report? The URL you mentioned taking this patch from is not upstream.
There was a problem hiding this comment.
I see the patch was proposed to upstream two years ago with no comment yet:
aircrack-ng/aircrack-ng#1957 (comment)
I see the patch was proposed to Homebrew two years ago and they decided not to use it:
There was a problem hiding this comment.
Patch is now changed to be applied unconditionally.
I think homebrew didn't take it because they require patches to be upstreamed first? There's also another patch in that PR which the author thought wasn't good enough that he ultimately closed it.
I have tested some of the binaries (especially aircrack-ng, with a test pcap file) on M2 and they seem to work fine. What doesn't work (capturing and stuff) doesn't work on x86 either.
|
Can we merge this now? |
|
This patch did not fix anything in the arm64 code; instead, it introduced syntax errors into the powerpc code: https://trac.macports.org/ticket/71326 |
taken from openwall/john@c9825e6
Description
Type(s)
Tested on
macOS 14.0 23A5276g arm64
Xcode 15.0 15A5161b
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?