Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost178, boost181: backport BOOST_CLANG_VERSION fix for LLVM clang #21067

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

chrstphrchvz
Copy link
Contributor

Description

I have not observed a specific error in MacPorts which this fixes, but since MacPorts often uses LLVM clang instead of Apple clang, it seems it would be beneficial to have this fix.

Type(s)
  • bugfix
Tested on

Not tested from MacPorts.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port boost178, boost181.
@michaelld for port boost178, boost181.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Oct 25, 2023
@michaelld
Copy link
Contributor

@chrstphrchvz are other boostXYZ, with XYZ != 178 or 181, not effected by this issue? For example between 178 and 181 MP has 179 and 180 ... usually the code like this is not that different between versions, hence my wondering

@mascguy
Copy link
Member

mascguy commented Oct 25, 2023

@chrstphrchvz are other boostXYZ, with XYZ != 178 or 181, not effected by this issue? For example between 178 and 181 MP has 179 and 180 ... usually the code like this is not that different between versions, hence my wondering

Michael, I've pruned our Boost ports considerably, as maintenance was starting to become burdensome.

So now there's only:

  • boost171
  • boost176
  • boost178
  • boost181

@mascguy
Copy link
Member

mascguy commented Oct 25, 2023

Michael, I've pruned our Boost ports considerably, as maintenance was starting to become burdensome.

So now there's only:

  • boost171
  • boost176
  • boost178
  • boost181

Eventually we'll add a newer version too - and there's an open enhancement request for that - but there hasn't been the need.

@mascguy
Copy link
Member

mascguy commented Oct 25, 2023

Michael, I've pruned our Boost ports considerably, as maintenance was starting to become burdensome.

So now there's only:

  • boost171
  • boost176
  • boost178
  • boost181

P.s. Originally I had hoped to drop 178 too, but there are a few ports that don't work with 181 yet. (And didn't want to risk any issues by dropping back to 176, in case those ports need newer features in 178.)

@chrstphrchvz
Copy link
Contributor Author

Currently, this is applicable to boost 1.78 and later, and I do not know if boost 1.84 will include this change. So boost178 and boost181 are the only ports affected.

@michaelld
Copy link
Contributor

@chrstphrchvz thanks for the thorough explanation! I'm clearly out of the loop & playing catch up with the state of ports. I fully support paring down ports where it can be done, so thank you for that work!

@michaelld michaelld merged commit 4b64e4f into macports:master Oct 26, 2023
@chrstphrchvz chrstphrchvz deleted the boost-clang-version branch October 26, 2023 00:54
@catap
Copy link
Contributor

catap commented Dec 19, 2023

Shall boostorg/mpl#77 be backported as well?

@kencu
Copy link
Contributor

kencu commented Dec 20, 2023

Shall boostorg/mpl#77 be backported as well?

they haven't accepted that one yet, it seems, and there is a competing idea going here:

#21839

@kencu
Copy link
Contributor

kencu commented Dec 20, 2023

I took it back to the upstream issue to see if we can get the fix that boost will officially integrate:

boostorg/mpl#69 (comment)

@kencu
Copy link
Contributor

kencu commented Dec 20, 2023

boost 181 builds fine on MacPorts with clang-17. I was expecting it to fail, given the above three comments.

boost 176 does fail on MacPorts with clang-17, as we know. Perhaps all we need is the fix in this PR there? Let me try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

6 participants