-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost178, boost181: backport BOOST_CLANG_VERSION
fix for LLVM clang
#21067
Conversation
Notifying maintainers: |
@chrstphrchvz are other boostXYZ, with XYZ != 178 or 181, not effected by this issue? For example between 178 and 181 MP has 179 and 180 ... usually the code like this is not that different between versions, hence my wondering |
Michael, I've pruned our Boost ports considerably, as maintenance was starting to become burdensome. So now there's only:
|
Eventually we'll add a newer version too - and there's an open enhancement request for that - but there hasn't been the need. |
P.s. Originally I had hoped to drop 178 too, but there are a few ports that don't work with 181 yet. (And didn't want to risk any issues by dropping back to 176, in case those ports need newer features in 178.) |
Currently, this is applicable to boost 1.78 and later, and I do not know if boost 1.84 will include this change. So boost178 and boost181 are the only ports affected. |
@chrstphrchvz thanks for the thorough explanation! I'm clearly out of the loop & playing catch up with the state of ports. I fully support paring down ports where it can be done, so thank you for that work! |
Shall boostorg/mpl#77 be backported as well? |
they haven't accepted that one yet, it seems, and there is a competing idea going here: |
I took it back to the upstream issue to see if we can get the fix that boost will officially integrate: |
boost 181 builds fine on MacPorts with clang-17. I was expecting it to fail, given the above three comments. boost 176 does fail on MacPorts with clang-17, as we know. Perhaps all we need is the fix in this PR there? Let me try that. |
Description
I have not observed a specific error in MacPorts which this fixes, but since MacPorts often uses LLVM clang instead of Apple clang, it seems it would be beneficial to have this fix.
Type(s)
Tested on
Not tested from MacPorts.
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?