Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv: Bump version to 20.0.13 and add dependencies #6365

Closed
wants to merge 10 commits into from

Conversation

rdbisme
Copy link
Contributor

@rdbisme rdbisme commented Feb 11, 2020

Add py-distlib port that is a depenency of virtualenv

Fix this bug: pypa/virtualenv#1581

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.2
Xcode 11.3.1

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@larryv for port py-virtualenv.

python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
@macportsbot

This comment has been minimized.

@mf2k
Copy link
Contributor

mf2k commented Feb 12, 2020

The commit message needs to be modified. Ideally this would be 2 commits. One for the new port, which needs to be mentioned in this commit. And the other commit for "py-virtualenv" not "virtualenv" as the current CM calls it.

@macportsbot

This comment has been minimized.

@macportsbot

This comment has been minimized.

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me there are some issues with the dependencies that need to get sorted out before this can be merged (and a few minor details)

python/py-distlib/Portfile Outdated Show resolved Hide resolved
python/py-distlib/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
@rdbisme rdbisme force-pushed the virtualenv branch 7 times, most recently from 701afa5 to afe0926 Compare February 13, 2020 15:19
@rdbisme
Copy link
Contributor Author

rdbisme commented Feb 13, 2020

The new version 20.0.3 gives an error about __version__.py file. I think they need to fix it.

:info:build AttributeError: module 'virtualenv' has no attribute '__version__'
:info:build Command failed:  cd "/opt/local/var/macports/build/_Users_rubendibattista_git_macports-ports_python_py-virtualenv/py37-virtualenv/work/virtualenv-20.0.3" && /opt/local/Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7 setup.py --no-user-cfg build -j8

@macportsbot

This comment has been minimized.

depends_lib-append port:py${python.version}-appdirs \
port:py${python.version}-distlib \
port:py${python.version}-filelock \
port:py${python.version}-setuptools \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't depend on setuptools 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all the python ports depend on setuptools?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope 👍 only old-style setup.py builds (which are not supported anymore) so hope we don't do that... if you build via pip or pep-517 this should not be needed

Copy link
Contributor Author

@rdbisme rdbisme Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, could you please link me an example of a portfile using PEP-517 or pip to install? I tried to grep around but I didn't find anything useful... Or it's automatic with the PG?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do build with setup.py so the build- and runtime dependency on setuptools is needed here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools does not support this behaviour anymore, other than backwards compatible way, so you might probably want to change to pip and wheels 🤷‍♂️

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

virtualenv itself uses pep 517 and 518 standards to build itself, so I don't think you'll be able to build without provisioning first the build system per pep-518

@@ -46,7 +66,7 @@ if {${name} ne ${subport}} {
post-destroot {
set docdir ${prefix}/share/doc/${subport}
xinstall -d ${destroot}${docdir}/docs/changelog
xinstall -m 0644 -W ${worksrcpath} README.rst LICENSE.txt AUTHORS.txt \
xinstall -m 0644 -W ${worksrcpath} README.md LICENSE \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed? why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a previous review @reneeotten made me keep these files. :)

python/py-virtualenv/Portfile Outdated Show resolved Hide resolved
python/py-virtualenv/Portfile Show resolved Hide resolved
@rdbisme rdbisme force-pushed the virtualenv branch 2 times, most recently from 3089a39 to feda1e9 Compare February 13, 2020 18:12
@rdbisme rdbisme changed the title virtualenv: Bump version to 20.0.2 and add dependencies virtualenv: Bump version to 20.0.3 and add dependencies Feb 13, 2020
@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 13, 2020

I think this is quite important, since the current version has bugs with subprocess? Can we merge this and then, as soon as 20.0.6 will come out, I'll update again?

@gaborbernat
Copy link

I'd wait for Monday, pypa/virtualenv#1711 will land this weekend with 20.0.11 👍

@macportsbot
Copy link

Travis Build #10695 Errored.

Lint results
--->  Verifying Portfile for py-appdirs
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-distlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-filelock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-importlib-metadata
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-importlib-resources
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-more-itertools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools_scm
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-six
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-toml
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-wheel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-zipp
--->  0 errors and 0 warnings found.

Port py38-appdirs success on xcode10.3. Log
Port py-appdirs success on xcode10.3. Log
Port py27-appdirs success on xcode10.3. Log
Port py34-appdirs success on xcode10.3. Log
Port py35-appdirs success on xcode10.3. Log
Port py36-appdirs success on xcode10.3. Log
Port py37-appdirs success on xcode10.3. Log
Port py38-distlib success on xcode10.3. Log
Port py-distlib success on xcode10.3. Log
Port py27-distlib success on xcode10.3. Log
Port py34-distlib success on xcode10.3. Log
Port py35-distlib success on xcode10.3. Log
Port py36-distlib success on xcode10.3. Log
Port py37-distlib success on xcode10.3. Log
Port py38-filelock success on xcode10.3. Log
Port py-filelock success on xcode10.3. Log
Port py27-filelock success on xcode10.3. Log
Port py34-filelock success on xcode10.3. Log
Port py35-filelock success on xcode10.3. Log
Port py36-filelock success on xcode10.3. Log
Port py37-filelock success on xcode10.3. Log
Port py38-importlib-metadata success on xcode10.3. Log
Port py-importlib-metadata success on xcode10.3. Log
Port py27-importlib-metadata success on xcode10.3. Log
Port py38-appdirs success on xcode9.4. Log
Port py-appdirs success on xcode9.4. Log
Port py27-appdirs success on xcode9.4. Log
Port py34-appdirs success on xcode9.4. Log
Port py35-appdirs success on xcode9.4. Log
Port py36-appdirs success on xcode9.4. Log
Port py37-appdirs success on xcode9.4. Log
Port py38-distlib success on xcode9.4. Log
Port py-distlib success on xcode9.4. Log
Port py27-distlib success on xcode9.4. Log
Port py34-distlib success on xcode9.4. Log
Port py35-distlib success on xcode9.4. Log
Port py36-distlib success on xcode9.4. Log
Port py37-distlib success on xcode9.4. Log
Port py38-filelock success on xcode9.4. Log
Port py-filelock success on xcode9.4. Log
Port py27-filelock success on xcode9.4. Log
Port py34-filelock success on xcode9.4. Log
Port py35-filelock success on xcode9.4. Log
Port py36-filelock success on xcode9.4. Log
Port py37-filelock success on xcode9.4. Log
Port py38-importlib-metadata success on xcode9.4. Log
Port py-importlib-metadata success on xcode9.4. Log
Port py27-importlib-metadata success on xcode9.4. Log
Port py34-importlib-metadata success on xcode9.4. Log
Port py38-appdirs success on xcode8.3. Log
Port py-appdirs success on xcode8.3. Log
Port py27-appdirs success on xcode8.3. Log
Port py34-appdirs success on xcode8.3. Log
Port py35-appdirs success on xcode8.3. Log
Port py36-appdirs success on xcode8.3. Log
Port py37-appdirs success on xcode8.3. Log
Port py38-distlib success on xcode8.3. Log
Port py-distlib success on xcode8.3. Log
Port py27-distlib success on xcode8.3. Log
Port py34-distlib success on xcode8.3. Log
Port py35-distlib success on xcode8.3. Log
Port py36-distlib success on xcode8.3. Log
Port py37-distlib success on xcode8.3. Log
Port py38-filelock success on xcode8.3. Log
Port py-filelock success on xcode8.3. Log
Port py27-filelock success on xcode8.3. Log
Port py34-filelock success on xcode8.3. Log
Port py35-filelock success on xcode8.3. Log
Port py36-filelock success on xcode8.3. Log
Port py37-filelock success on xcode8.3. Log
Port py38-importlib-metadata success on xcode8.3. Log
Port py-importlib-metadata success on xcode8.3. Log
Port py27-importlib-metadata success on xcode8.3. Log
Port py34-importlib-metadata success on xcode8.3. Log
Port py35-importlib-metadata success on xcode8.3. Log
Port py36-importlib-metadata success on xcode8.3. Log
Port py37-importlib-metadata success on xcode8.3. Log
Port py36-importlib-resources success on xcode8.3. Log
Port py-importlib-resources success on xcode8.3. Log
Port py38-appdirs success on xcode7.3. Log
Port py-appdirs success on xcode7.3. Log
Port py27-appdirs success on xcode7.3. Log
Port py34-appdirs success on xcode7.3. Log
Port py35-appdirs success on xcode7.3. Log
Port py36-appdirs success on xcode7.3. Log
Port py37-appdirs success on xcode7.3. Log
Port py38-distlib success on xcode7.3. Log
Port py-distlib success on xcode7.3. Log
Port py27-distlib success on xcode7.3. Log
Port py34-distlib success on xcode7.3. Log
Port py35-distlib success on xcode7.3. Log
Port py36-distlib success on xcode7.3. Log
Port py37-distlib success on xcode7.3. Log
Port py38-filelock success on xcode7.3. Log
Port py-filelock success on xcode7.3. Log
Port py27-filelock success on xcode7.3. Log
Port py34-filelock success on xcode7.3. Log
Port py35-filelock success on xcode7.3. Log
Port py36-filelock success on xcode7.3. Log
Port py37-filelock success on xcode7.3. Log
Port py38-importlib-metadata success on xcode7.3. Log
Port py-importlib-metadata success on xcode7.3. Log
Port py27-importlib-metadata success on xcode7.3. Log
Port py34-importlib-metadata success on xcode7.3. Log
Port py35-importlib-metadata success on xcode7.3. Log
Port py36-importlib-metadata success on xcode7.3. Log
Port py37-importlib-metadata success on xcode7.3. Log

The build timed out.

@macportsbot
Copy link

Travis Build #10741 Errored.

Lint results
--->  Verifying Portfile for py-appdirs
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-distlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-filelock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-importlib-metadata
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-importlib-resources
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-more-itertools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools_scm
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-six
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-toml
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-wheel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-zipp
--->  0 errors and 0 warnings found.

Port py38-appdirs success on xcode10.3. Log
Port py-appdirs success on xcode10.3. Log
Port py27-appdirs success on xcode10.3. Log
Port py34-appdirs success on xcode10.3. Log
Port py35-appdirs success on xcode10.3. Log
Port py36-appdirs success on xcode10.3. Log
Port py37-appdirs success on xcode10.3. Log
Port py38-distlib success on xcode10.3. Log
Port py-distlib success on xcode10.3. Log
Port py27-distlib success on xcode10.3. Log
Port py34-distlib success on xcode10.3. Log
Port py35-distlib success on xcode10.3. Log
Port py36-distlib success on xcode10.3. Log
Port py37-distlib success on xcode10.3. Log
Port py38-filelock success on xcode10.3. Log
Port py-filelock success on xcode10.3. Log
Port py27-filelock success on xcode10.3. Log
Port py34-filelock success on xcode10.3. Log
Port py35-filelock success on xcode10.3. Log
Port py36-filelock success on xcode10.3. Log
Port py37-filelock success on xcode10.3. Log
Port py38-importlib-metadata success on xcode10.3. Log
Port py-importlib-metadata success on xcode10.3. Log
Port py27-importlib-metadata success on xcode10.3. Log
Port py34-importlib-metadata success on xcode10.3. Log
Port py38-appdirs success on xcode9.4. Log
Port py-appdirs success on xcode9.4. Log
Port py27-appdirs success on xcode9.4. Log
Port py34-appdirs success on xcode9.4. Log
Port py35-appdirs success on xcode9.4. Log
Port py36-appdirs success on xcode9.4. Log
Port py37-appdirs success on xcode9.4. Log
Port py38-distlib success on xcode9.4. Log
Port py-distlib success on xcode9.4. Log
Port py27-distlib success on xcode9.4. Log
Port py34-distlib success on xcode9.4. Log
Port py35-distlib success on xcode9.4. Log
Port py36-distlib success on xcode9.4. Log
Port py37-distlib success on xcode9.4. Log
Port py38-filelock success on xcode9.4. Log
Port py-filelock success on xcode9.4. Log
Port py27-filelock success on xcode9.4. Log
Port py34-filelock success on xcode9.4. Log
Port py35-filelock success on xcode9.4. Log
Port py36-filelock success on xcode9.4. Log
Port py37-filelock success on xcode9.4. Log
Port py38-importlib-metadata success on xcode9.4. Log
Port py-importlib-metadata success on xcode9.4. Log
Port py38-appdirs success on xcode8.3. Log
Port py-appdirs success on xcode8.3. Log
Port py27-appdirs success on xcode8.3. Log
Port py34-appdirs success on xcode8.3. Log
Port py35-appdirs success on xcode8.3. Log
Port py36-appdirs success on xcode8.3. Log
Port py37-appdirs success on xcode8.3. Log
Port py38-distlib success on xcode8.3. Log
Port py-distlib success on xcode8.3. Log
Port py27-distlib success on xcode8.3. Log
Port py34-distlib success on xcode8.3. Log
Port py35-distlib success on xcode8.3. Log
Port py36-distlib success on xcode8.3. Log
Port py37-distlib success on xcode8.3. Log
Port py38-filelock success on xcode8.3. Log
Port py-filelock success on xcode8.3. Log
Port py27-filelock success on xcode8.3. Log
Port py34-filelock success on xcode8.3. Log
Port py35-filelock success on xcode8.3. Log
Port py36-filelock success on xcode8.3. Log
Port py37-filelock success on xcode8.3. Log
Port py38-importlib-metadata success on xcode8.3. Log
Port py-importlib-metadata success on xcode8.3. Log
Port py27-importlib-metadata success on xcode8.3. Log
Port py34-importlib-metadata success on xcode8.3. Log
Port py35-importlib-metadata success on xcode8.3. Log
Port py36-importlib-metadata success on xcode8.3. Log
Port py37-importlib-metadata success on xcode8.3. Log
Port py36-importlib-resources success on xcode8.3. Log
Port py-importlib-resources success on xcode8.3. Log
Port py27-importlib-resources success on xcode8.3. Log
Port py34-importlib-resources success on xcode8.3. Log
Port py38-appdirs success on xcode7.3. Log
Port py-appdirs success on xcode7.3. Log
Port py27-appdirs success on xcode7.3. Log
Port py34-appdirs success on xcode7.3. Log
Port py35-appdirs success on xcode7.3. Log
Port py36-appdirs success on xcode7.3. Log
Port py37-appdirs success on xcode7.3. Log
Port py38-distlib success on xcode7.3. Log
Port py-distlib success on xcode7.3. Log
Port py27-distlib success on xcode7.3. Log
Port py34-distlib success on xcode7.3. Log
Port py35-distlib success on xcode7.3. Log
Port py36-distlib success on xcode7.3. Log
Port py37-distlib success on xcode7.3. Log
Port py38-filelock success on xcode7.3. Log
Port py-filelock success on xcode7.3. Log
Port py27-filelock success on xcode7.3. Log
Port py34-filelock success on xcode7.3. Log
Port py35-filelock success on xcode7.3. Log
Port py36-filelock success on xcode7.3. Log
Port py37-filelock success on xcode7.3. Log
Port py38-importlib-metadata success on xcode7.3. Log
Port py-importlib-metadata success on xcode7.3. Log
Port py27-importlib-metadata success on xcode7.3. Log
Port py34-importlib-metadata success on xcode7.3. Log
Port py35-importlib-metadata success on xcode7.3. Log
Port py36-importlib-metadata success on xcode7.3. Log
Port py37-importlib-metadata success on xcode7.3. Log
Port py36-importlib-resources success on xcode7.3. Log
Port py-importlib-resources success on xcode7.3. Log

The build timed out.

@rdbisme rdbisme changed the title virtualenv: Bump version to 20.0.5 and add dependencies virtualenv: Bump version to 20.0.13 and add dependencies Mar 20, 2020
@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 20, 2020

Ok, I updated at the last version available. :). Please merge this since the available version on Macports is bugged.

@gaborbernat
Copy link

This is now ready to go 👍

@emcrisostomo
Copy link
Member

@reneeotten your requested changes are outdated. Can you have a look at them to confirm this merge is now OK?

@reneeotten reneeotten self-assigned this Mar 21, 2020
@reneeotten
Copy link
Contributor

okay, I will take care of getting this merged. There are still a few minor points left (e.g., py-setuptools should be upgrade to its latest version and that's a maintained port, so one would need give the maintainer some time to respond). So I will fetch this PR locally, make some minor changes where required, and commit the pieces already that are good-to-go. Once that's done, I will force-push the remaining ports to this PR and we should be able to get this update merged. Sounds okay @rubendibattista ?

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 21, 2020

@reneeotten Ehi, I think it's ok even if I believe that this could land now and with another PR then you could upload setuptools. Otherwise with my and your lags, we will never merge it :)

@reneeotten
Copy link
Contributor

@reneeotten Ehi, I think it's ok even if I believe that this could land now and with another PR then you could upload setuptools. Otherwise with my and your lags, we will never merge it :)

there were still some issues regarding dependencies with this PR, but I'm almost done with it. There is no need to update py-setuptools, so I am just leaving it out; additionally I've squashed the addition of py34-suborts into one commit. Currently testing to see if everything works as intended and then I'll push it to master and we can close this PR. Stay tuned ;) and thanks for your work!

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 21, 2020

@reneeotten Ok! Thanks for the support!

@reneeotten
Copy link
Contributor

I just committed your new/updated ports with a few modifications to make sure everything works correctly. Thanks again for the update and sorry that it took so long this time get this committed!

@rdbisme
Copy link
Contributor Author

rdbisme commented Mar 21, 2020

So we can close this PR I guess. Thanks to everybody for helping me!

@rdbisme rdbisme closed this Mar 21, 2020
@rdbisme rdbisme deleted the virtualenv branch October 17, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants