Prevent leaking password reset token through Referrer header #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2017
|
@macropin @dicato I tried to go through a list of similar apps that might have issues to alert them: https://djangopackages.org/grids/g/registration/ |
joshblum
commented
Jun 8, 2017
registration/auth_urls.py
Outdated
| @@ -27,35 +27,54 @@ | |||
| from django.core.urlresolvers import reverse_lazy | |||
| from django.contrib.auth import views as auth_views | |||
|
|
|||
| # Attempt to use the auth class based views if available. | |||
| try: | |||
| login_view = auth_views.LoginView.as_view() | |||
There was a problem hiding this comment.
need to pass kwargs to as_view to override defaults
|
@joshblum sorry for the delay. Looks good to me! Do you want to fix the use of "referrer" to "referer"? Probably good to be consistent with the original misspelling. |
|
@dicato great! fixed the misspellings and will merge/pypy bump after tests :) |
3 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #266, preventing the leaking of password reset token through the
Referrerheader.For Django 1.11+, we fix by using the newer class based views.
For versions of Django below 1.11 we add a
metablock to the template add at the meta tag<meta name="referrer" content="never">. In addition, we addrel="noreferrer"to the password reset email.