Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACS3 3.0.0 official release with docs updated #597

Merged
merged 46 commits into from
Nov 15, 2023
Merged

Conversation

taoliu
Copy link
Contributor

@taoliu taoliu commented Nov 9, 2023

No description provided.

Copy link
Contributor

@philippadoherty philippadoherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks great, very thorough. The comments I made are primarily formatting and minor text changes for clarity or grammar fixes.

A few other files that were not changed for this PR:

  • The ChangeLog file doesn't have any updates after 3.0.0.b3, is that correct?
  • on Contributing.md, some links broken to documentation - we could consider linking to readme.md #usage section.
  • We could consider explicitly mentioning in the readme - that windows OS not supported, either in readme.md or INSTALL.md?
  • Does the INSTALL.md file need updating for this version?
  • on conda/meta.yaml: {% set version = "3.0.0b3" %} update version

docs/callpeak.md Outdated Show resolved Hide resolved
docs/bdgpeakcall.md Outdated Show resolved Hide resolved
docs/callvar.md Show resolved Hide resolved
docs/callvar.md Outdated Show resolved Hide resolved
docs/callvar.md Outdated Show resolved Hide resolved
docs/predictd.md Outdated Show resolved Hide resolved
docs/predictd.md Outdated Show resolved Hide resolved
docs/refinepeak.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@philippadoherty philippadoherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@taoliu taoliu merged commit ae83986 into master Nov 15, 2023
18 checks passed
@taoliu taoliu deleted the doc/macs3/3.0.0b4 branch September 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants