Add dark mode customization / appearance preferences panel #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new preference that allows specifying how MacVim will use dark mode: use systems preference (default), force light mode, force dark mode, or use Vim's 'background' option to decide. Preference will be stored in defaults as 'MMAppearanceModeSelection'. Add docs for that as well. Also, add a new preferences panel called "Appearance" to allow setting the dark mode setting, and transparent titlebar as well. Setting it will refresh all Vim windows immediately for feedback. Also, when setting titlebars to transparent, also hide the file icon as it's distracting in what's a more minimalistic display. Don't use another preference for that for now to avoid having too many options. Minor: Remove preference panel's cross-fade effect as it's more distracting than useful. Fix macvim-dev#912 Also: - See macvim-dev#1015 for part of the contribution. - Close macvim-dev#266 - Close macvim-dev#933
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Jul 6, 2020
This adds a new appearance option in Preferences to pick hiding title bar (in addition to using the transparent look). It was already an option before but this exposes it in the UI. Also, fix setting title to cache properly. Also fix non-native fullscreen to respect appearance changing in the Preferences pane. Also, see macvim-dev#1038 which added appareance pane.
ychin
added a commit
that referenced
this pull request
Aug 13, 2020
Vim patch 8.2.1424 Features - New "Appearance" option pane (accessible via Cmd-, or MacVim -> Preferences) to allow customizing how MacVim looks. Users can now select how MacVim works with Dark Mode, and configure titlebar to be hidden or transparent. #912 #1038 #1056 - MacVim localization support. It now uses translated Vim messages for the specified locale. See `:help multilang-messages` to see how to configure it. #991 General: - Python is now built against 3.8, up from 3.7. #1012 Fixes: - Fix mvim:// protocol handler behavior. Reverts behavior back to old behavior (before snapshot-162), but add new fallback handling to try to handle poorly formed URLs that don't double-encode special characters. See `:help macvim://`. #1055 - Can now change tabs using menu and keyboard shortcuts (Cmd-{ / Cmd-} / Cmd-T) when in terminal mode. #1045 Targets macOS 10.9+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.8 - Ruby 2.7
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Aug 15, 2020
Vim patch 8.2.1456 Features - New "Appearance" option pane (accessible via Cmd-, or MacVim -> Preferences) to allow customizing how MacVim looks. Users can now select how MacVim works with Dark Mode, and configure titlebar to be hidden or transparent. macvim-dev#912 macvim-dev#1038 macvim-dev#1056 - MacVim localization support. It now uses translated Vim messages for the specified locale. See `:help multilang-messages` to see how to configure it. macvim-dev#991 General: - Python is now built against 3.8, up from 3.7. macvim-dev#1012 Fixes: - Fix mvim:// protocol handler behavior. Reverts behavior back to old behavior (before snapshot-162), but add new fallback handling to try to handle poorly formed URLs that don't double-encode special characters. See `:help macvim://`. macvim-dev#1055 - Can now change tabs using menu and keyboard shortcuts (Cmd-{ / Cmd-} / Cmd-T) when in terminal mode. macvim-dev#1045 - Fix crash during MacVim launch in Snapshot 164 (8.2.1424) due to dynamic library linkage. macvim-dev#1073 Targets macOS 10.9+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.8 - Ruby 2.7
ychin
added a commit
that referenced
this pull request
Aug 15, 2020
Vim patch 8.2.1456 Features - New "Appearance" option pane (accessible via Cmd-, or MacVim -> Preferences) to allow customizing how MacVim looks. Users can now select how MacVim works with Dark Mode, and configure titlebar to be hidden or transparent. #912 #1038 #1056 - MacVim localization support. It now uses translated Vim messages for the specified locale. See `:help multilang-messages` to see how to configure it. #991 General: - Python is now built against 3.8, up from 3.7. #1012 Fixes: - Fix mvim:// protocol handler behavior. Reverts behavior back to old behavior (before snapshot-162), but add new fallback handling to try to handle poorly formed URLs that don't double-encode special characters. See `:help macvim://`. #1055 - Can now change tabs using menu and keyboard shortcuts (Cmd-{ / Cmd-} / Cmd-T) when in terminal mode. #1045 - Fix crash during MacVim launch in Snapshot 164 (8.2.1424) due to dynamic library linkage. #1073 Targets macOS 10.9+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.8 - Ruby 2.7
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new preference that allows specifying how MacVim will use dark mode: use systems preference (default), force light mode, force dark mode, or use Vim's 'background' option to decide. Preference will be stored in defaults as 'MMAppearanceModeSelection'. Add docs for that as well.
Also, add a new preferences panel called "Appearance" to allow setting the dark mode setting, and transparent titlebar as well. Setting it will refresh all Vim windows immediately for feedback.
Also, when setting titlebars to transparent, also hide the file icon as it's distracting in what's a more minimalistic display. Don't use another preference for that for now to avoid having too many options.
Minor: Remove preference panel's cross-fade effect as it's more distracting than useful.
Fix #912
Also: