Allow never opening window + terminate on last window, with guards #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last window" This reverts commit f6ba7dd. This change was reverted as part of macvim-dev#1338 as we want to implement a different solution.
Previously we disabled this combo in f6ba7dd because when implemented naively, it causes an issue where just opening an About MacVim or Settings window could immediately cause MacVim to exit (because macOS determined that there were no non-auxillary window open). This was awkward and potentially made it hard to change the setting back, and exact behavior depended on OS behavior. However, it seems like there are legit use case for this combo of settings. Change it so that we allow setting both of them again, but add checks so that `applicationShouldTerminateAfterLastWindowClosed:` will only return `YES` if we have opened at least one Vim window before. This gives the user a chance to open a window first, so using Settings etc wouldn't immediately terminate the app. Fix macvim-dev#1338
ychin
force-pushed
the
allow-untitled-window-never-terminate-window-again
branch
from
e1cab27 to
cabb495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we disabled this combo in f6ba7dd because when implemented naively, it causes an issue where just opening an About MacVim or Settings window could immediately cause MacVim to exit (because macOS determined that there were no non-auxillary window open). This was awkward and potentially made it hard to change the setting back, and exact behavior depended on OS behavior.
However, it seems like there are legit use case for this combo of settings. Change it so that we allow setting both of them again, but add checks so that
applicationShouldTerminateAfterLastWindowClosed:will only returnYESif we have opened at least one Vim window before. This gives the user a chance to open a window first, so using Settings etc wouldn't immediately terminate the app.Fix #1338