Fix macOS 14 Sonoma non-native full screen background color #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-native full screen's configured background color (default to black) stopped working when building using macOS 14 SDK, because the main CoreText view was now drawing over it in drawRect, due to the new clipToBounds property defaulting to false in macOS 14 SDK. We could just fix this issue by setting clipToBounds to true on the text view, but we would lose the benefits of the new behavior which allows us to show tall texts (e.g. Tibetan texts or other characters with composing chars) on the first line and not have it be clipped at the top. Currently with the unclipped behavior, the character can be drawn and poke up into the window frame or the notch area. To properly fix this, just clip the background color fill in drawRect, and allow texts etc to still draw outside the rect.
ychin
added
Renderer
|
The new macOS 14 behavior (not clipping views by default) actually allows tall texts on the first line to not be clipped now, as they are allowed to be drawn further above. This works both in regular windowed mode and non-native full screen. Sadly, for native full screen the text will still be clipped because macOS doesn't really allow you to use the notch area in native full screen. Windowed: 
Non-native full screen (only when not showing menu bar). The black part is the notch area (the black color can be configured by 
|
ychin
added a commit
that referenced
this pull request
Jan 5, 2024
Updated to Vim 9.1.0 Vim 9.1 is now released! See [announcement](https://www.vim.org/vim-9.1-released.php). Features ==================== System monospace font (SF Mono) -------------------- MacVim's `guifont` option now supports a new `-monospace-` value, which instructs it to use the system monospace font, which is SF Mono in recent macOS versions. As mentioned below, you can now use tab-completion to see the available values in cmdline. See `:h macvim-guifont` for more details on how to use it (including using different font weights). #1463 Note: I'm contemplating changing the MacVim defaults to use `-monospace-` in the future so MacVim will always use the native monospace font instead of being hard-coded to Menlo. This makes it more consistent with Apple Terminal and Xcode. Feel free to leave a comment on #1277 if you have opinions on this. New Vim features -------------------- - Command-line tab completion improvements and bug fixes - Most string option values can now be completed. v9.0.1958 - MacVim options (guifont, fuoptions) also support tab completion. #1436 - ++opt (e.g. `:e ++`) and `:terminal ++` completion works as well. v9.0.2025 - New options: - `set jumpoptions=stack`. Ported from Neovim. v9.0.1921 - API changes - `getmousepos()` returns a new "coladd" for tab characters. v9.0.2032 - `:Man` now works properly when `gdefault` is set. - A new small Vim script library that may expand in the future. See `:h vim-script-library`. - Vim9 script improvements. - Miscellaneous security fixes. Misc -------------------- New settings: - "Scroll in one direction only" (Input). Prevents accidental horizontal scrolling when scrolling vertically using a trackpad. #1442 Clean mode (#1453): - Vim can be opened in clean mode (does not use .vimrc or plugins) via the new menu item "New Clean Window". The new menu isn't localized in most languages. Please comment on the issue if you would like to help in localization. - MacVim can be launched without loading user defaults for a clean experience via a command-line flag. See `:h macvim-settings`. General ==================== - Sparkle (updater for MacVim) is now updated to 2.5.2. The updater can now show multiple release notes when updating MacVim across multiple versions. #1446 #1469 - Binary release is now built with more optimized compiler settings. Vim will now run slightly faster than before. #1444 - macOS 14 Sonoma: - Binary release is now built using the macOS 14 SDK (#1434, #1440, #1448). One small change is that very tall characters (e.g. "นี้") on the first line will now draw into the title bar instead of being clipped. - Fixed printing with `:hardcopy` under macOS 14. *NOTE:* Starting from macOS 14, you have to install `ps2pdf` (available from Ghostscript) yourself before you can print. See #1464 - Python 2 support: The default location for locating the Python 2 lib in the binary release is now under /Library/Frameworks rather than /usr/local. Note: Python 2 has long been obsolete. If you rely on Python 2 plugins, consider this a warning as it's only supported as long as it's feasible and could be removed in the future. #1434 Fixes ==================== - Fixed non-native full screen mode when using a MacBook with a notch and having the "Show menu bar in non-native mode" option set. Changing the screen resolution while using non-native full screen also works properly now. #1450 - Fixed Help menu's documentation search not working with tags with special characters like `<Down>`. #1455 Compatibility ==================== Requires macOS 10.9 or above. (10.9 - 10.12 requires downloading a separate legacy build) Script interfaces have compatibility with these versions: - Lua 5.4 - Perl 5.30 - Python2 2.7 - Python3 3.9 or above - Ruby 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-native full screen's configured background color (default to black) stopped working when building using macOS 14 SDK, because the main CoreText view was now drawing over it in drawRect, due to the new clipToBounds property defaulting to false in macOS 14 SDK.
We could just fix this issue by setting clipToBounds to true on the text view, but we would lose the benefits of the new behavior which allows us to show tall texts (e.g. Tibetan texts or other characters with composing chars) on the first line and not have it be clipped at the top. Currently with the unclipped behavior, the character can be drawn and poke up into the window frame or the notch area.
To properly fix this, just clip the background color fill in drawRect, and allow texts etc to still draw outside the rect.