Refactor MacVim tests and add startup delayed full screen tests #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
the
Non User Facing
ychin
force-pushed
the
tests-refactor-add-fullscreen-delayed
branch
2 times, most recently
from
91840e2 to
332f2ca
Compare
Add test suite utility functions to set/restore defaults, adding/tearing down a new Vim window, making temp files, wait for full screen transition. This helps simplify per-test code and prevent mistakes. Add new tests for delayed full screen on startup. This happens when a vimrc/gvimrc sets 'fullscreen' on startup and MacVim has to delay entering full screen until the window has been presented. This incidentally regression tests a bug (fixed in macvim-dev#1521) where simply having 'set fuopt= fullscreen' in a gvimrc would cause MacVim to crash on startup due to bad interaction with window resize messages.
ychin
force-pushed
the
tests-refactor-add-fullscreen-delayed
branch
from
332f2ca to
e33658a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test suite utility functions to set/restore defaults, adding/tearing down a new Vim window, making temp files, wait for full screen transition. This helps simplify per-test code and prevent mistakes.
Add new tests for delayed full screen on startup. This happens when a vimrc/gvimrc sets 'fullscreen' on startup and MacVim has to delay entering full screen until the window has been presented. This incidentally regression tests a bug (fixed in #1521) where simply having 'set fuopt= fullscreen' in a gvimrc would cause MacVim to crash on startup due to bad interaction with window resize messages.