Only override 'guitablabel' if user hasn't already set it #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If guitablabel is already set in .vimrc, don't have the MacVim default gvimrc override it. Even though Vim's docs recommend putting GUI settings in gvimrc, that's mostly for technical reasons, and MacVim should still aim to respect settings that a user has already set. This also makes it behave more similarly with Vim (you can set 'guitablabel' in vimrc or gvimrc and it would still work). This was previously done in macvim-dev#635 but reverted, but macvim-dev#899 raised this issue again. Close macvim-dev#899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If guitablabel is already set in .vimrc, don't have the MacVim default gvimrc override it. Even though Vim's docs recommend putting GUI settings in gvimrc, that's mostly for technical reasons, and MacVim should still aim to respect settings that a user has already set. This also makes it behave more similarly with Vim (you can set 'guitablabel' in vimrc or gvimrc and it would still work).
This was previously done in #635 but reverted, but #899 raised this issue again.
Close #899