Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unwrap in storage #100

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented May 6, 2024

fix: remove unwrap in storage

Pull Request type

  • Bugfix

What is the current behavior?

  • if the block sync stops with the storage updates already in db but not the block, when restarting the program crashes

What is the new behavior?

  • remove unwrap in the storage

Does this introduce a breaking change?

Other information

@jbcaron jbcaron self-assigned this May 6, 2024
Copy link
Member

@cchudant cchudant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@antiyro antiyro merged commit da86f80 into madara-alliance:main May 6, 2024
7 checks passed
@jbcaron jbcaron deleted the fix/sync branch May 23, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants